On 05/03/2018 03:12 AM, Vladimir Sementsov-Ogievskiy wrote:
+ + - 16 bits, `NBD_INFO_TRIM_SIZE` + - 32 bits, minimum trim size + - 32 bits, maximum trim sizetrailing whitespaces here (and not only here).
Intentional. That is markdown's syntax for doing a nice bulleted list with proper line breaks. The rendered html is much different if you omit those spaces. (I hate that markdown has significant trailing whitespace - but I didn't invent the language).
@@ -1794,6 +1847,9 @@ The following request types exist: negotiated using `NBD_OPT_STRUCTURED_REPLY`. The client SHOULD NOT request a read length of 0; the behavior of a server on such a request is unspecified although the server SHOULD NOT disconnect. + The optional `NBD_INFO_BLOCK_SIZE` information sent during + `NBD_OPT_GO` can provide more details about any read alignment + constraints.hmm, I'm not sure about "alignment" word. You've used "alignment and sizes"in similar situation in previous version. Do "alignment" include maximum constraint? (similarquestion for other commands below).
I can add "and sizes" if that makes it easier to follow. In fact, I might push this (and related hunks on existing commands) independently of the changes to add new alternative limits.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org