[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH v2] doc: Improvements to block-status



01.05.2018 00:37, Eric Blake wrote:
On 04/03/2018 04:15 PM, Eric Blake wrote:

Once qemu 2.12 is released, I will also merge extension-blockstatus into
mainline

That has now happened.  I'm also proposing this followup patch, based on this mail to the qemu list, which proposes the addition of a "qemu:dirty-bitmap:name" meta context:

https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg01981.html

(The file mentioned doesn't actually document the NBD context exposure to dirty bitmaps yet, so this patch depends on the qemu patch being updated to actually update that file; or tweak this patch if qemu folks create a new file instead...)


From 4941ed0db9a13fa6e99282b10eaa740ce9bdb175 Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake@redhat.com>
Date: Mon, 30 Apr 2018 16:25:51 -0500
Subject: [PATCH] doc: Register qemu namespace for NBD_OPT_SET_META_CONTEXT

An upcoming qemu release will add an additional supported context
namespace to its NBD_OPT_SET_META_CONTEXT implementation, named
"qemu:".  This serves as a registration of that third-party
namespace, while pointing to qemu documentation for the
specification of leaf-names within that namespace (currently just
a "dirty-bitmap:" sub-namespace that can select a named
dirty bitmap), and what they represent.  We don't have to track
the full details of the qemu implementation (especially since
qemu may add more sub-namespace or bit definitions over time),
but merely link to qemu documentation that should remain
up-to-date.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 doc/proto.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/proto.md b/doc/proto.md
index 6cc0fe2..2878744 100644
--- a/doc/proto.md
+++ b/doc/proto.md
@@ -891,7 +891,7 @@ Namespaces MUST be consist of one of the following:
 Third-party implementations can register additional namespaces by
 simple request to the mailing-list. The following additional
 third-party namespaces are currently registered:
-* (none)
+* `qemu`, maintained by [qemu.org](https://git.qemu.org/?p=qemu.git;a=blob;f=docs/interop/bitmaps.rst)

 Save in respect of the `base:` namespace described below, this specification
 requires no specific semantics of metadata contexts, except that all the

Good idea, thank you. I'll think about interop/* patches for qemu.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir


Reply to: