Re: [PATCH 1/3] nbd: del_gendisk after we cleanup the queue

To: "kernel-team@fb.com" <kernel-team@fb.com>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "josef@toxicpanda.com" <josef@toxicpanda.com>, "nbd@other.debian.org" <nbd@other.debian.org>, "axboe@kernel.dk" <axboe@kernel.dk>, "alex@iss-integration.com" <alex@iss-integration.com>
Cc: "jbacik@fb.com" <jbacik@fb.com>, "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] nbd: del_gendisk after we cleanup the queue
From: Bart Van Assche <Bart.VanAssche@wdc.com>
Date: Fri, 13 Apr 2018 16:16:18 +0000
Message-id: <[🔎] 0a8b3a85910e7bbe0103120e85844e96341d73ec.camel@wdc.com>
In-reply-to: <[🔎] 20180413160334.5496-1-josef@toxicpanda.com>
References: <[🔎] 20180413160334.5496-1-josef@toxicpanda.com>

On Fri, 2018-04-13 at 12:03 -0400, Josef Bacik wrote:
> This fixes a use after free bug, we need to do the del_gendisk after we
> cleanup the queue on the device.

Hello Josef,

Which use-after-free bug does this patch fix? Are you aware that most block
drivers call blk_cleanup_queue() before calling del_gendisk()? Why do you
think that the nbd driver should use the opposite order?

Thanks,

Bart.

Reply to:

Follow-Ups:
- Re: [PATCH 1/3] nbd: del_gendisk after we cleanup the queue
  - From: Josef Bacik <josef@toxicpanda.com>

References:
- [PATCH 1/3] nbd: del_gendisk after we cleanup the queue
  - From: Josef Bacik <josef@toxicpanda.com>

Prev by Date: Re: [PATCH 1/3] nbd: del_gendisk after we cleanup the queue
Next by Date: Re: [PATCH] proto: add xNBD command NBD_CMD_CACHE to the spec
Previous by thread: [PATCH 3/3] nbd: use bd_set_size when updating disk size
Next by thread: Re: [PATCH 1/3] nbd: del_gendisk after we cleanup the queue
Index(es):
- Date
- Thread