Re: [PATCH v2] structured-reply: Tweak some protocol requirements

[Wouter Verhelst <w@uter.be>]

Hi Eric,

On Thu, Oct 26, 2017 at 09:55:32AM +0200, Eric Blake wrote:
[...]
> @@ -1362,13 +1368,13 @@ interpret the "length" bytes of payload.
> 
>  - `NBD_REPLY_TYPE_OFFSET_DATA` (1)
> 
> -  This chunk type is in the content chunk category.  *length* MUST
> -  be at least 9.  It represents the contents of *length - 8* bytes
> -  of the file, starting at *offset*.  The data MUST lie within the
> -  bounds of the original offset and length of the client's
> -  request, and MUST NOT overlap with the bounds of any earlier
> -  content chunk or error chunk in the same reply.  This chunk MAY
> -  be used more than once in a reply, unless the `NBD_CMD_FLAG_DF`
> +  This chunk type is in the content chunk category.  *length* MUST be
> +  at least 9.  It represents the contents of *length - 8* bytes of the
> +  file, starting at the absolute *offset* of the export.  The data

I would maybe make that

  the absolute *offset* from the start of the export

since I'm not sure that "the absolute offset of the export" is clear
enough.

Just a thought.

Other than that, LGTM

-- 
Could you people please use IRC like normal people?!?

  -- Amaya Rodrigo Sastre, trying to quiet down the buzz in the DebConf 2008
     Hacklab