[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: nbd structured reply



fix cc to nbd@other.debian.org

05.10.2017 14:30, Vladimir Sementsov-Ogievskiy wrote:
21.09.2017 15:18, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

I'm about this:

"A server SHOULD try to minimize the number of chunks sent in a reply, but MUST NOT mark a chunk as final if there is still a possibility of detecting an error before transmission of that chunk completes"

What do we mean by "possibility"? Formally, such possibility exists always, so, we'll never mark a chunk as final.


One more question:

for NBD_REPLY_TYPE_ERROR and NBD_REPLY_TYPE_ERROR_OFFSET, why do we need message_length field? why not to calc it as chunk.lenght - 4 for NBD_REPLY_TYPE_ERROR and chunk.lenght - 12 for NBD_REPLY_TYPE_ERROR_OFFSET?

For example, with NBD_REPLY_TYPE_OFFSET_DATA variable data length is calculated, not specified separately.

What is the reason for server to send NBD_REPLY_TYPE_ERROR with message_lenght < chunk.lenght - 4?


-- 
Best regards,
Vladimir


-- 
Best regards,
Vladimir

Reply to: