Re: [Nbd] [PATCH] proto: add 'shift' extension.
- To: Kevin Wolf <kwolf@...696...>
- Cc: nbd-general@lists.sourceforge.net, Vladimir Sementsov-Ogievskiy <vsementsov@...2319...>, stefanha@...696..., qemu-block@...530..., qemu-devel@...530..., w@...112..., Paolo Bonzini <pbonzini@...696...>
- Subject: Re: [Nbd] [PATCH] proto: add 'shift' extension.
- From: "Denis V. Lunev" <den@...2319...>
- Date: Wed, 28 Sep 2016 11:37:45 +0300
- Message-id: <efb4ad09-6d09-e508-09a3-0473f72643c4@...2319...>
- In-reply-to: <20160928083415.GC5236@...2331...>
- References: <1474893981-5302-1-git-send-email-vsementsov@...2319...> <27bd2bc9-b879-81ef-c7b6-31335e6be84f@...2319...> <912490881.3041685.1474971311025.JavaMail.zimbra@...696...> <61b997ac-f9b9-37a2-6a0b-412ad77ddedd@...2319...> <2133222015.3059876.1474978044995.JavaMail.zimbra@...696...> <2c6d5867-3f0b-3ae6-3d3c-7b515243f39a@...2319...> <be2487a2-7ace-de87-ff56-09093ceca544@...696...> <e5fff718-251b-15a5-7501-950cacb7f52a@...2319...> <20160928083415.GC5236@...2331...>
On 09/28/2016 11:34 AM, Kevin Wolf wrote:
> Am 27.09.2016 um 20:59 hat Denis V. Lunev geschrieben:
>> On 09/27/2016 08:04 PM, Paolo Bonzini wrote:
>>> On 27/09/2016 15:28, Denis V. Lunev wrote:
>>>> On 09/27/2016 03:07 PM, Paolo Bonzini wrote:
>>>>> ----- Original Message -----
>>>>>> From: "Denis V. Lunev" <den@...2319...>
>>>>>> To: "Paolo Bonzini" <pbonzini@...696...>
>>>>>> Cc: "Vladimir Sementsov-Ogievskiy" <vsementsov@...2319...>, qemu-devel@...530..., qemu-block@...530...,
>>>>>> nbd-general@lists.sourceforge.net, alex@...872..., eblake@...696..., kwolf@...696..., stefanha@...696...,
>>>>>> w@...112...
>>>>>> Sent: Tuesday, September 27, 2016 12:25:54 PM
>>>>>> Subject: Re: [PATCH] proto: add 'shift' extension.
>>>>>>
>>>>>> On 09/27/2016 01:15 PM, Paolo Bonzini wrote:
>>>>>>>> We could go in a different direction and export flag
>>>>>>>> 'has_zero_init' which will report that the storage is
>>>>>>>> initialized with all zeroes at the moment. In this
>>>>>>>> case mirroring code will not fall into this
>>>>>>>> branch.
>>>>>>> Why don't you add the zero_init flag to QEMU's NBD driver instead?
>>>>>> for all cases without knowing real backend on the server side?
>>>>>> I think this would be wrong.
>>>>> Add it to the command line, and leave it to libvirt or the user to
>>>>> pass "-drive file.driver=nbd,...,file.zero-init=on".
>>>> I have started with something very similar for 'drive-mirror' command.
>>>> We have added additional flag for this to improve migration speed
>>>> and this was rejected.
>>> You can add it through the filename path too, through a URI option
>>> "nbd://...?zero-init=on".
>>>
>>> Paolo
>> ha, cool idea! Thanks!
> What's the advantage of writing "?zero-init=on" instead of
> ",zero-init=on"? Doesn't it only add more string parsing code for no
> benefit?
>
> Kevin
Here I appreciate the idea to pass command line options in the
target file name. Will it be performed via comma or '?' - there
is no difference for us. We will check and use what is already
implemented.
The most important for us is an approach.
Den
Reply to: