Re: [Nbd] [PATCH] proto: add 'shift' extension.
- To: "Denis V. Lunev" <den@...2319...>
- Cc: nbd-general@lists.sourceforge.net, kwolf@...696..., Vladimir Sementsov-Ogievskiy <vsementsov@...2319...>, stefanha@...696..., qemu-block@...530..., qemu-devel@...530..., w@...112...
- Subject: Re: [Nbd] [PATCH] proto: add 'shift' extension.
- From: Paolo Bonzini <pbonzini@...696...>
- Date: Tue, 27 Sep 2016 08:07:25 -0400 (EDT)
- Message-id: <2133222015.3059876.1474978044995.JavaMail.zimbra@...696...>
- In-reply-to: <61b997ac-f9b9-37a2-6a0b-412ad77ddedd@...2319...>
- References: <1474893981-5302-1-git-send-email-vsementsov@...2319...> <27bd2bc9-b879-81ef-c7b6-31335e6be84f@...2319...> <912490881.3041685.1474971311025.JavaMail.zimbra@...696...> <61b997ac-f9b9-37a2-6a0b-412ad77ddedd@...2319...>
----- Original Message -----
> From: "Denis V. Lunev" <den@...2319...>
> To: "Paolo Bonzini" <pbonzini@...696...>
> Cc: "Vladimir Sementsov-Ogievskiy" <vsementsov@...2319...>, qemu-devel@...530..., qemu-block@...530...,
> nbd-general@lists.sourceforge.net, alex@...872..., eblake@...696..., kwolf@...696..., stefanha@...696...,
> w@...112...
> Sent: Tuesday, September 27, 2016 12:25:54 PM
> Subject: Re: [PATCH] proto: add 'shift' extension.
>
> On 09/27/2016 01:15 PM, Paolo Bonzini wrote:
> >> We could go in a different direction and export flag
> >> 'has_zero_init' which will report that the storage is
> >> initialized with all zeroes at the moment. In this
> >> case mirroring code will not fall into this
> >> branch.
> > Why don't you add the zero_init flag to QEMU's NBD driver instead?
>
> for all cases without knowing real backend on the server side?
> I think this would be wrong.
Add it to the command line, and leave it to libvirt or the user to
pass "-drive file.driver=nbd,...,file.zero-init=on".
Paolo
Reply to: