Re: [Nbd] Testing NBD server implementations for correctness
- To: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@...2724...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>, Wouter Verhelst <w@...112...>, libguestfs@...696...
- Subject: Re: [Nbd] Testing NBD server implementations for correctness
- From: Alex Bligh <alex@...872...>
- Date: Mon, 26 Sep 2016 11:43:42 +0100
- Message-id: <6E87D159-3DAA-4C94-A99C-2EE9EBD1F7A6@...872...>
- In-reply-to: <57E8E895.3030103@...2724...>
- References: <57E74AFB.4070506@...2724...> <5720E25C-93C9-4DDB-B871-93DC5BA9CD5F@...872...> <20160925112411.byjfmv7qotamd7m4@...3...> <57E8786C.7050306@...2724...> <20160926075320.ubnz3aeszclsrcf2@...3...> <57E8E895.3030103@...2724...>
> On 26 Sep 2016, at 10:21, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@...2724...> wrote:
>
> Wow, that was quick! Thank you.
>
> I stumbled upon another problem: Apparently nbd-tester-client and nbdkit
> disagree on what constitutes a valid flush request.
> nbd-tester-client complains:
> ./flush
> 15901: Requests: 3536
> ** (process:15901): WARNING **: Could not run test: Received error from
> server: 22 (0x16). Handle is -9223372036854764544 (0x8000000000002C00).
>
> nbdkit complains:
> nbdkit: python[7]: error: invalid flush request: expecting offset and
> length == 0
>
> Not sure where that bug is, nbdkit or nbd-tester-client.
> - Is the request correct and should have been accepted?
> - Is the reject correct, but the response is screwed up?
Per the docs:
• For a flush request, length and offset are reserved, and MUST be set to all-zero.
So if nbd-tester-client.c is sending a flush with non-zero length or offset, it is wrong.
--
Alex Bligh
Reply to: