On 31 Mar 2016, at 20:14, Eric Blake <eblake@...696...> wrote: >> >> >> Should we produce a new name for it (and future command flags) >> that aren't shifted left 16 places, and just maintain the >> current value for compatibility? > > I don't see the point. Your fix looks correct. OK. And the wrongness hasn't yet got into /usr/include/linux/nbd.h or include/uapi/linux/nbd.h ; these have no reference to FUA at all, even though it does have NBD_FLAG_SEND_FLUSH, which is odd as I added both flags at the same time. So I'm guessing it's safe. -- Alex Bligh
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail