Re: [Nbd] [PATCH v2 5/6] nbd: Test recent bug fixes

[Wouter Verhelst <w@...112...>]

On Thu, Oct 20, 2016 at 01:48:50PM -0500, Eric Blake wrote:
> On 10/20/2016 02:31 AM, Wouter Verhelst wrote:
> >> Trickier said than done.  There is no 'testflags' parameter passed all
> >> the way into setup_connection_common(), so it would require quite a bit
> >> of additional framework to decide whether to do normal connection
> >> (return a socket ready for further reads) or a short connection (return
> >> a socket still in the middle of negotiation so we can test further
> >> options).  But I'll play with the idea.
> > 
> > Change the CONECTION_TYPE enum, adding a CONNECTION_TYPE_WRONGOPT (or some
> > such) to it? That enum was meant as that "framework" ;-)
> > 
> 
> my v3 changed the TEST_ enum instead, but I'll see if I can redo it to
> trigger off of a CONNECTION_TYPE_ value.

You can if you want to, but the code you sent was fine as well. It's not
been applied only because the other bits that I did merge conflict with
it, and I've been busy doing other things rather than fixing up commit
conflicts.

I'll probably look at it again tomorrow, or if you want to send me an
updated patch that applies on current git HEAD, that would work too.

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12