[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH v2 5/6] nbd: Test recent bug fixes



On 10/20/2016 02:31 AM, Wouter Verhelst wrote:
>> Trickier said than done.  There is no 'testflags' parameter passed all
>> the way into setup_connection_common(), so it would require quite a bit
>> of additional framework to decide whether to do normal connection
>> (return a socket ready for further reads) or a short connection (return
>> a socket still in the middle of negotiation so we can test further
>> options).  But I'll play with the idea.
> 
> Change the CONECTION_TYPE enum, adding a CONNECTION_TYPE_WRONGOPT (or some
> such) to it? That enum was meant as that "framework" ;-)
> 

my v3 changed the TEST_ enum instead, but I'll see if I can redo it to
trigger off of a CONNECTION_TYPE_ value.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: