Re: [Nbd] [PATCH] Fix flags processing to avoid bogus read-only export
- To: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>
- Cc: Wouter Verhelst <w@...112...>
- Subject: Re: [Nbd] [PATCH] Fix flags processing to avoid bogus read-only export
- From: Alex Bligh <alex@...872...>
- Date: Wed, 4 May 2016 11:46:37 +0100
- Message-id: <9B789D2C-4A60-4771-B68F-790D4905EBCF@...872...>
- In-reply-to: <1462358724-45491-1-git-send-email-alex@...872...>
- References: <1462358724-45491-1-git-send-email-alex@...872...>
On 4 May 2016, at 11:45, Alex Bligh <alex@...872...> wrote:
> As described here:
> https://www.mail-archive.com/nbd-general@lists.sourceforge.net/msg03878.html
>
> NBD clients prior to 3.10 incorrectly attempt to merge the server flags
> with the transmission flags. This means that any such client cannot connect
> to a server (e.g. NBD server post 3.10, gonbdserver) which supports
> NBD_FLAG_NO_ZEROES without making the export read-only.
>
> This one line fix avoids the issue by simply passing the kernel the
> transmission flags without an attempt to merge them. This is the
> behaviour nbd-client (post 3.10) does, and also qemu's current behaviour.
This is against 3.7, obviously.
If people are OK about this, how do I get this upstream? I'm happy
to file an Ubuntu bug but I'm wondering if Wouter is the Debian
maintainer, and indeed whether we (I?) can simply push it as a branch.
--
Alex Bligh
Reply to: