[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] doc/proto.txt partial rewrite


On Tue, Jul 14, 2015 at 04:03:33PM +0200, Wouter Verhelst wrote:
> Hi folks,
> proto.txt was getting a bit messy, with it repeating itself a few times
> (sometimes even contradicting itself) and little structure in general.
> I've tried to fix that. You can see the list of changes (20 of them) on
> <https://github.com/yoe/nbd/compare/proto-markdown>.
> Note that while there are 20 commits, and that while I tried to create
> them so that every commit makes sense and is self-contained, I actually
> only did so after I'd pretty much done the whole thing. This was because
> at that point I noticed that it would be better to chop things up into
> small commits, so that it could be more easily reviewed; especially as
> it's pretty much become a de facto standards document, I'd hate to
> introduce errors by lack of paying attention.
> As such, I would obviously love it if someone could make some time and
> review the changes that I've done.

This looks very good. The structure is quite good to follow and
everything is understandable. I didn't look into the specific patches,
just the resulting documentation. I also didn't use a markdown parser to
have a look at the result.

Best regards,


Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: Digital signature

Reply to: