[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] 3.12 BUG() on ext4, kernel crash on nbd-client when nbd server rebooting

On Monday, November 18, 2013, Wouter Verhelst wrote:
Op 18-11-13 23:17, Paul Clements schreef:
> Right, some rearrangement of the ioctls would be required too...we'd
> probably want alternate versions of SET_SOCK and DO_IT that are
> re-entrant (right now those will error on an already-configured device,
> and they're doing some setup and teardown that is unneeded in the
> reconnect case).

Since all this is a significant departure of the current API, I suppose
it would be good if there would be a way for the client to detect what
the currently-running kernel supports, without having to resort to
things like calling 'uname -r' (or equivalent in C code) or extensive
error handling based on "that ioctl isn't supported, so let's fall back
to previous API versions."

Anything specific that would make it easier from your perspective?  One thought is to have SET_FLAGS fail when an unknown flag is passed. Or say a get_capabilities() type call?

This end should point toward the ground if you want to go to space.

If it starts pointing toward space you are having a bad problem and you
will not go to space today.

  -- http://xkcd.com/1133/

Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
Nbd-general mailing list

Reply to: