[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] Random NBD connection shutdowns...



> > a few months ago I noticed that nbd-client (kmod code actually) randomly
> > shuts down the connection during heavy parallel xdd benchmarks in my
> > local setup.  The following change to nbd.c fixed that for me:
> > 
> > @@ -303,9 +303,13 @@
> >         struct request *req, *tmp;
> >         int err;
> >  
> > +wait:
> >         err = wait_event_interruptible(nbd->active_wq, nbd->active_req != xreq);
> > -       if (unlikely(err))
> > +       if (unlikely(err)) {
> > +               if (err == -ERESTARTSYS)
> > +                       goto wait;
> >                 goto out;
> > +       }
> > 
> > Please consider pushing it upstream.
> > Thanks!
> 
> I was able to hit this bug with the stock nbd-server, it is NOT
> bnbd-specific.  If this mailing list is the wrong place to submit NBD

I also hit this bug with the stock nbd-server. Also informed about this
problem, then.


Folkert van Heusden

-- 
MultiTail is a versatile tool for watching logfiles and output of
commands. Filtering, coloring, merging, diff-view, etc.
http://www.vanheusden.com/multitail/
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com



Reply to: