[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Nbd] Random NBD connection shutdowns...



Hi there,

a few months ago I noticed that nbd-client (kmod code actually) randomly
shuts down the connection during heavy parallel xdd benchmarks in my
local setup.  The following change to nbd.c fixed that for me:

@@ -303,9 +303,13 @@
        struct request *req, *tmp;
        int err;
 
+wait:
        err = wait_event_interruptible(nbd->active_wq, nbd->active_req != xreq);
-       if (unlikely(err))
+       if (unlikely(err)) {
+               if (err == -ERESTARTSYS)
+                       goto wait;
                goto out;
+       }

Please consider pushing it upstream.
Thanks!

-- 
Michal Belczyk Sr.



Reply to: