Re: [Nbd] nbd & discard/trim
- To: Wouter Verhelst <w@...112...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] nbd & discard/trim
- From: Paul Clements <paul.clements@...856...>
- Date: Tue, 28 Aug 2012 09:27:44 -0400
- Message-id: <CAECXXi7BTQ7y66JArDi9O3CRBCvECKtKfFUGt2VjSyNks=dPNQ@...18...>
- In-reply-to: <20120828130602.GA21943@...3...>
- References: <20120809105752.GD14886@...855...> <20120809115751.GB22589@...3...> <CAECXXi7qU4sHK0=+wWTod-z7q94ZKuZWR2WengSPNRb414BuDA@...18...> <20120809153507.GE14886@...855...> <CAECXXi4=STwkUL3YRyrLPD+p2mwUKS3wt8vtEmW2KQbdu_52NA@...18...> <CAECXXi73O6cuwnfWQ6fCcTiYjGj6PUMUs3SOBiuJz2qCA2LZLQ@...18...> <20120828130602.GA21943@...3...>
On Tue, Aug 28, 2012 at 9:06 AM, Wouter Verhelst <w@...112...> wrote:
> On Thu, Aug 23, 2012 at 09:57:13AM -0400, Paul Clements wrote:
>> OK, attached are the two patches that I have queued. The first adds
>> the SET_FLAGS ioctl. The second adds the TRIM/DISCARD support. Once
>> people have had a chance to review and (ideally) test the patches I'll
>> push to mainline. In particular, can someone please verify these
>> patches are compatible with current nbd tools -- specifically the
>> ioctl and flag values. I think I've got those right, but I'd like to
>> be sure.
>
> Seems so; I just ran git HEAD nbd-client against Linux 3.6 commit
> 5cca7e2e, and I could connect and disconnect just fine.
>
> Sorry this took so long. It'd been about 10 years now since I last
> compiled my own kernels regularly, and apparently I've gotten somewhat
> rusty in figuring out which drivers I need and which I don't. But I got
> it to work in the end.
Thanks Wouter, appreciate your testing this. I will go ahead and push these...
--
Paul
Reply to: