Re: [Nbd] [PATCH 2/2] nbd-server: remove unused CFILE_ -error codes
- To: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH 2/2] nbd-server: remove unused CFILE_ -error codes
- From: Wouter Verhelst <w@...112...>
- Date: Mon, 31 Dec 2012 10:01:31 +0100
- Message-id: <20121231090131.GC16921@...3...>
- In-reply-to: <20121230211436.GA16920@...1259...>
- References: <20121230211436.GA16920@...1259...>
On Sun, Dec 30, 2012 at 11:14:36PM +0200, Tuomas Jorma Juhani Räsänen wrote:
> Signed-off-by: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
> ---
> nbd-server.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/nbd-server.c b/nbd-server.c
> index 217a07a..7cfbe01 100644
> --- a/nbd-server.c
> +++ b/nbd-server.c
> @@ -613,13 +613,10 @@ SERVER* cmdline(int argc, char *argv[]) {
> typedef enum {
> CFILE_NOTFOUND, /**< The configuration file is not found */
> CFILE_MISSING_GENERIC, /**< The (required) group "generic" is missing */
> - CFILE_KEY_MISSING, /**< A (required) key is missing */
> CFILE_VALUE_INVALID, /**< A value is syntactically invalid */
> CFILE_VALUE_UNSUPPORTED,/**< A value is not supported in this build */
> CFILE_NO_EXPORTS, /**< A config file was specified that does not
> define any exports */
> - CFILE_INCORRECT_PORT, /**< The reserved port was specified for an
> - old-style export. */
> CFILE_DIR_UNKNOWN, /**< A directory requested does not exist*/
> CFILE_READDIR_ERR, /**< Error occurred during readdir() */
> } CFILE_ERRORS;
> --
> 1.7.10.4
NAK, sorry. The fact that these aren't used doesn't mean we need to
remove them, it means we may need to add checks -- unless you have a
good argument why they don't make sense?
--
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.
Reply to: