Re: [Nbd] [PATCH 2/2] nbd-server: remove unused CFILE_ -error codes
- To: Wouter Verhelst <w@...112...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH 2/2] nbd-server: remove unused CFILE_ -error codes
- From: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
- Date: Mon, 31 Dec 2012 19:29:16 +0200
- Message-id: <20121231172916.GA8492@...1259...>
- In-reply-to: <20121231090131.GC16921@...3...>
- References: <20121230211436.GA16920@...1259...> <20121231090131.GC16921@...3...>
On Mon, Dec 31, 2012 at 10:01:31AM +0100, Wouter Verhelst wrote:
>
> NAK, sorry. The fact that these aren't used doesn't mean we need to
> remove them, it means we may need to add checks -- unless you have a
> good argument why they don't make sense?
>
No problem. I think it's a matter of taste. I am used to keeping
source code free of unreferenced code. But I can see your point in
keeping these hanging around, as reminders, until the corresponding
test is implemented.
Either way, it isn't biggie.
--
Tuomas
Reply to: