Re: [Nbd] [PATCH] nbd-server: replace msg2(), msg3() and msg4() with variadic msg()

[Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>]

On Sun, Dec 30, 2012 at 03:16:15AM +0100, Wouter Verhelst wrote:
> On Sat, Dec 29, 2012 at 10:21:57PM +0200, Tuomas Jorma Juhani Räsänen wrote:
> > 
> > True. I considered variadic macros, too, for a few seconds. But then I
> > thought that macros would not be that much more effective and I didn't
> > know which you'd prefer,
> 
> Well, the code already has a variadic macro 4 lines lower, that could've given
> you a hint... ;-)

Oh yes, it was a hint, but just a hint. Having a certain kind of
construct or pattern in the old code does not necessarily mean that
you would accept the same kind of construct in a new code. At least
not until the whole codebase is as clean and smooth as [imagine
something really clean and smooth].

> > You are quite fast/efficient in applying patches, nice! =)
> 
> Only when they're all this simple and easy to review. If you start sending me
> larger patches, I might require more time ;-)
> 

Challenge accepted.

-- 
Tuomas