Re: [Nbd] [PATCH] nbd-server: replace msg2(), msg3() and msg4() with variadic msg()
- To: Wouter Verhelst <w@...112...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH] nbd-server: replace msg2(), msg3() and msg4() with variadic msg()
- From: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
- Date: Sat, 29 Dec 2012 22:21:57 +0200
- Message-id: <20121229202157.GA21127@...1259...>
- In-reply-to: <20121229115236.GL30316@...3...>
- References: <20121228213300.GA20523@...1259...> <20121229115236.GL30316@...3...>
On Sat, Dec 29, 2012 at 12:52:36PM +0100, Wouter Verhelst wrote:
>
> I've applied this too, but after I did so and pushed it I started
> thinking that, because it really only calls one function, it might be
> better, for now, to use a C99-style variadic macro instead. I've changed
> it in that way.
>
True. I considered variadic macros, too, for a few seconds. But then I
thought that macros would not be that much more effective and I didn't
know which you'd prefer, so I decided to offer the "safer" one
first. But yes, macros are even simpler in this case, so good call!
You are quite fast/efficient in applying patches, nice! =)
--
Tuomas
Reply to: