Re: [Nbd] [PATCH] nbd: nbd sysfs framework
- To: Paul Clements <paul.clements@...856...>
- Cc: nbd-general@lists.sourceforge.net, andrew morton <akpm@...133...>, kernel list <linux-kernel@...25...>
- Subject: Re: [Nbd] [PATCH] nbd: nbd sysfs framework
- From: Greg KH <greg@...926...>
- Date: Wed, 3 Aug 2011 22:22:39 -0700
- Message-id: <20110804052239.GA12523@...926...>
- In-reply-to: <CAECXXi5pkRAY_dVSwSUrj5RQzsJ2YVx6xXovzpuRDOEOq92s9g@...18...>
- References: <CAECXXi5kZJk+86-2SJRWqMUCj31cL4tb1qTbaueMxeEg2VFcDw@...18...> <20110803233426.GA18216@...926...> <CAECXXi5pkRAY_dVSwSUrj5RQzsJ2YVx6xXovzpuRDOEOq92s9g@...18...>
On Wed, Aug 03, 2011 at 10:17:04PM -0400, Paul Clements wrote:
> On Wed, Aug 3, 2011 at 7:34 PM, Greg KH <greg@...926...> wrote:
> > On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote:
> >> Description: The patch creates a new sysfs entry framework for nbd.
> >
> > Why? What does this buy us except an increase in code size for no added
> > benifit? You seem to be stripping out the driver layer here and using
> > "raw" kobjects, why?
>
> Not sure what I was thinking...just in a hurry, I think.
>
> Is the following a little better?
I don't know, I still fail to understand _why_ this patch is needed.
Why are you doing this? What is the goal? What is wrong with the
existing code that it doesn't work for you?
confused,
greg k-h
Reply to: