Re: [Nbd] [PATCH] nbd: nbd sysfs framework
- To: Paul Clements <paul.clements@...856...>
- Cc: nbd-general@lists.sourceforge.net, andrew morton <akpm@...133...>, kernel list <linux-kernel@...25...>
- Subject: Re: [Nbd] [PATCH] nbd: nbd sysfs framework
- From: Greg KH <greg@...926...>
- Date: Wed, 3 Aug 2011 16:34:26 -0700
- Message-id: <20110803233426.GA18216@...926...>
- In-reply-to: <CAECXXi5kZJk+86-2SJRWqMUCj31cL4tb1qTbaueMxeEg2VFcDw@...18...>
- References: <CAECXXi5kZJk+86-2SJRWqMUCj31cL4tb1qTbaueMxeEg2VFcDw@...18...>
On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote:
> Description: The patch creates a new sysfs entry framework for nbd.
Why? What does this buy us except an increase in code size for no added
benifit? You seem to be stripping out the driver layer here and using
"raw" kobjects, why? That's generally never a good idea (hint, I think
you just caused a race and userspace bug with your change as well
because of this...)
confused,
greg k-h
Reply to: