Re: [Nbd] Current HEAD fails make check

[Alex Bligh <alex@...872...>]

--On 9 June 2011 16:26:38 +0200 Wouter Verhelst <w@...112...> wrote:

> > [generic]
> >         oldstyle = true
> > [export]
> >         exportname = /tmp/foo
> >         port = 11112
>
> If you run nbd-server with a config file, open_modern is always called.
> You can't switch that off.

OK. So if open_modern is always called with a config file,
what does "oldstyle=true" do? Is open_modern not the opposite
of oldstyle?

> This is by design; I want to deprecate  oldstyle exports.

My favourite simplification here would be to untangle or the
oldstyle and newstyle stuff. If you specify a config file, you
ONLY get newstyle exports. If you don't and you specify a port
number on the command line, you ONLY get oldstyle exports. I
had thought that is what happened until I ran across "oldstyle = true".
I spent an hour trying to untangle it but I am afraid I gave up!

> It's fixed now. Sorry for the mixup.

No problem - thanks for fixing it.

--
Alex Bligh