Goswin,--On 22 May 2011 00:02:44 +0200 Goswin von Brederlow <goswin-v-b@...186...> wrote:
Wouldn't it make sense to allow offset and length to flush only parts of an NBD device? offset == length == 0 could be an alias for the whole disk.
One could do that. Currently the NBD_CMD_FLUSH implementation is modeled on Linux's REQ_FLUSH, which is a whole device command. Are there other users of nbd-server which would benefit from such a partial flush? You also end up with a question as to whether you would flush the metadata or no (fsync() flushes metadata but sync_file_range dones not). -- Alex Bligh