Re: [Nbd] [PATCH] fix documentation of NBD_CMD_FLUSH

[Goswin von Brederlow <goswin-v-b@...186...>]

Alex Bligh <alex@...872...> writes:

> Patch also available from
> http://git.alex.org.uk/nbd.git/commit/065a1b241dde2ab6fe333ccf5bc057e7e327f8d4
>
> ---
>  doc/proto.txt |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/doc/proto.txt b/doc/proto.txt
> index d173365..61c2401 100644
> --- a/doc/proto.txt
> +++ b/doc/proto.txt
> @@ -34,7 +34,8 @@ header consists a 32 bit magic number (magic), a 32 bit field denoting
>  the request type (see below; 'type'), a 64 bit handle ('handle'), a 64
>  bit data offset ('from'), and a 32 bit length ('len'). In case of a
>  write request, the header is immediately followed by 'len' bytes of
> -data.
> +data. In the case of NBD_CMD_FLUSH, the offset and length are
> +ignored.
>  
>  The reply contains three fields: a 32 bit magic number ('magic'), a 32
>  bit error code ('error'; 0, unless an error occurred in which case it is

Wouldn't it make sense to allow offset and length to flush only parts of
an NBD device? offset == length == 0 could be an alias for the whole
disk.

MfG
        Goswin