Re: [Nbd] use g_option_context_parse() instead of getopt_long().

[Wouter Verhelst <w@...112...>]

On Wed, Sep 15, 2010 at 01:37:10PM +0200, Laurent Vivier wrote:
> >Hi Laurent,
> 
> Hi Wouter,
> 
> >For nontrivial patches, I prefer if you could send them to this
> >mailinglist, so they can be more easily reviewed. I'm sorry about the
> 
> No problem, I was just playing with "request pull" feature of githup...

Hehe. Yeah, it's a compelling feature. But development discussions have
historically happened here, it makes sense to keep it that way.

[...]
> >Anyway. General note: this seems to run amiss of the "if it ain't
> >broken, don't fix it" mantra. Also, I'm not 100% sure I think it's a
> >good idea to move nbd-server to one API for command line parsing, and
> >nbd-client to another (I had finally synchronized them in that regard
> >:-)
> >
> >But I'm willing to go past all that if there's a compelling reason, of
> >course. What'd be the most important advantage?
> 
> I agree with all, I just try to make some cleanup.

Sure. I know how other people's code can be unreadable at times (been
there myself, too), and if you can suggest ways to reorganize things so
they're easier to read, that's of course always welcome. It's just this
particular case that's slightly different :-)

> There is really no problem with me if you think this patch (or other)
> is not "good". I try, you can accept or not.

Well, I won't then; I see no immediate advantage in switching to glib
option parsing (not like we use any gtk or glib options, anyway, so we
don't need to add groups from those libraries), and I do see a
disadvantage (in having to work with two different option parsers for
two fairly trivial applications).

[...]
> But should I drop it to trash or not ?

This one, I'm afraid so. But I'd hate to have suggested something like
that without having given you a chance to convince me otherwise first
:-)

-- 
The biometric identification system at the gates of the CIA headquarters
works because there's a guard with a large gun making sure no one is
trying to fool the system.
  http://www.schneier.com/blog/archives/2009/01/biometrics.html