[Nbd] use g_option_context_parse() instead of getopt_long().
- To: nbd-general@...72...
- Cc: Laurent Vivier <laurent@...823...>
- Subject: [Nbd] use g_option_context_parse() instead of getopt_long().
- From: Wouter Verhelst <w@...112...>
- Date: Wed, 15 Sep 2010 13:13:49 +0200
- Message-id: <20100915111347.GB31447@...510...>
Hi Laurent,
For nontrivial patches, I prefer if you could send them to this
mailinglist, so they can be more easily reviewed. I'm sorry about the
delay last time; I'll try to be better in the future.
Anyway. General note: this seems to run amiss of the "if it ain't
broken, don't fix it" mantra. Also, I'm not 100% sure I think it's a
good idea to move nbd-server to one API for command line parsing, and
nbd-client to another (I had finally synchronized them in that regard
:-)
But I'm willing to go past all that if there's a compelling reason, of
course. What'd be the most important advantage?
Also:
+ { "output-config", 'o', 0, G_OPTION_ARG_FILENAME,
+ &outputconfig, "output a config file section for what you "
+ "specified on the command line, with the specified section "
+ "name",
+ NULL },
That should probably be G_OPTION_ARG_STRING instead.
--
The biometric identification system at the gates of the CIA headquarters
works because there's a guard with a large gun making sure no one is
trying to fool the system.
http://www.schneier.com/blog/archives/2009/01/biometrics.html
Reply to: