[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1071219: marked as done (apt: debListParser fails to parse arch lists with extraneous whitespace: terminate called after throwing an instance of 'std::length_error')

Your message dated Sat, 25 May 2024 09:19:12 +0000
with message-id <E1sAnYW-00CBFs-Pf@fasolo.debian.org>
and subject line Bug#1071219: fixed in apt 2.9.4
has caused the Debian Bug report #1071219,
regarding apt: debListParser fails to parse arch lists with extraneous whitespace: terminate called after throwing an instance of 'std::length_error'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1071219: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071219
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: apt
Version: 2.9.2
Severity: serious

one package to reproduce this bug is mpich 4.2.0-5.1

mpich-4.2.0# apt-get build-dep -y .
Note, using directory '.' to get the build dependencies
terminate called after throwing an instance of 'std::length_error'
  what():  basic_string::_M_create
Aborted (core dumped)

Running this through gdb and extracting the interesting part of the
backtrace:

#11 0x00007ffff7e28c6c in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<char const*, void> (__a=...,
    __end=0x5555555baade " amd64 powerpc armhf],\n"...,
    __beg=0x5555555baadf "amd64 powerpc armhf],\n"..., this=0x7fffffffd670) at /usr/include/c++/13/bits/basic_string.h:765
#12 debListParser::ParseDepends (Start=<optimized out>,
    Start@entry=0x5555555baabb "valgrind [i386 arm64 ppc64el ppc64  amd64 powerpc armhf],\n"...,
    Stop=Stop@entry=0x5555555bab15 "\nBuild-Conflicts: libamdhip64-dev\n"..., Package=..., Ver=..., Op=@0x7fffffffd930: 0, ParseArchFlags=<optimized out>, StripMultiArch=<optimized out>, ParseRestrictionsList=<optimized out>, Arch=...) at ./apt-pkg/deb/deblistparser.cc:667

Note the double space in ..."ppc64  amd64"...
It tries to create a std::string with __end < __beg resulting in a
negative (or insane) length.

The nasty thing is that the error only happens if there has been no
match, yet. I.e on amd64  ..."amd64  ppc64el"... would *not* have
caused the error.
I'm not sure how to build a test string that reliably works on all
architectures...

Anyway, apt should be able to parse the following string correctly:

"Build-Depends:  foobar  [  i386 armhf  armel  amd64  ]  ,  blah  [  !arm64 !x32  !amd64  ]  ,  baz"
not sure if it is allowed to inject spaces between '!' and arch as in
..."  ppc64  !  mips64el ! s390x "...

(I noticed this due to the salsa-ci failure while building mpich)
e.g. https://salsa.debian.org/science-team/mpich/-/jobs/5731958

Andreas

PS: This will probably be "fixed" in mpich 4.2.0-6

--- End Message ---
--- Begin Message --- 
Source: apt
Source-Version: 2.9.4
Done: Julian Andres Klode <jak@debian.org>

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1071219@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Julian Andres Klode <jak@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 25 May 2024 10:58:49 +0200
Source: apt
Architecture: source
Version: 2.9.4
Distribution: unstable
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Julian Andres Klode <jak@debian.org>
Closes: 839546 1071219
Changes:
 apt (2.9.4) unstable; urgency=medium
 .
   [ David Kalnischkies ]
   * Fix accidental silencing of output differences in tests
   * Do not mark new if we have already installed providers
   * Do not save new if we have already installed providers (Closes: #839546)
   * Deal better with spurious spaces in arch restrictions (Closes: #1071219)
 .
   [ Julian Andres Klode ]
   * pkgcachegen: Do not try to chmod or write to /dev/null (LP: #2067138)
   * test: Show statistics for parallel tests too
   * test: Run working tests against the 3.0 solver, and adjust as many as possible
     (more bug fixes in a further release)
     - test: Temporarily ignore autoremovable lists for solver3
     - test: Support the 3.0 solver in most existing test cases
   * Various improvements to the 3.0 solver:
     - edsp: solver3: Show some progress
     - solver3: Implement APT::Solver::RemoveManual to allow removing manual packages
     - solver3: Promote satisfied Suggests to Recommends
     - solver3: Solve optional dependencies before optional packages
     - solver3: Try candidate before installed version on upgrade
     - solver3: Use stable sort
     - solver3: Actually restore unsolved items rather than solved ones
     - solver3: Fix translations of removals for marked install
Checksums-Sha1:
 c6efb125760c13b6068cecd280fc784cfefd11c6 2973 apt_2.9.4.dsc
 c9a6f467ce761b1cd5a127a433db316311881c5b 2380744 apt_2.9.4.tar.xz
 76723e71b248d095cb209f1f16c2fcdb2acb21cd 7763 apt_2.9.4_source.buildinfo
Checksums-Sha256:
 c569fa76428835b9861a6c665680b9f454af8ad0ad37a0a2c22a6a99a3b625f4 2973 apt_2.9.4.dsc
 45aea378933b9e468f656051ed2bfcf93bab02bb350f94e8754727eb17b407a4 2380744 apt_2.9.4.tar.xz
 c766ed10ac7c2f44922205af2a264752171303186c5d9243271d306ec9f71ee5 7763 apt_2.9.4_source.buildinfo
Files:
 7f564bbd7df5dc7ce21ba16e30b9dd58 2973 admin required apt_2.9.4.dsc
 0601ce72479e0845da54be218c037519 2380744 admin required apt_2.9.4.tar.xz
 9f001014915eb2c63d43914c5d88f23f 7763 admin required apt_2.9.4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEET7WIqEwt3nmnTHeHb6RY3R2wP3EFAmZRqWYPHGpha0BkZWJp
YW4ub3JnAAoJEG+kWN0dsD9xJikQAICCNNjoNMF86/tqJ0uEp+tjpIBIMD9B7cLq
JWxKVBClPR3DQCCiek1xmitY2XJqCN+9vb9y/VOiuvJVNpLnWCNLZ9OAKX25MyjK
5/YCFI7Erv0XncFg3AIhLhBz/kiAkWSykQ5LHcJfjqRmCxYw9NPv48qqPrw5uQaq
CKViNkdlpR3sbBsyxCSewXtihpBZIvnpaPNqrrgwyByDb6b1Np0/1a22Nmek0lRt
EKCmt+y/FVGcbfN+Ly1u7hBZf+uzSyrxJpDYXGRHITzEBvYkHPR+8Z48v3ZFcSef
OLLMyWuZJ2zioj2R/xwXRhlD1RYHkZmaSWf4StNC0Z6xwU6CykwDkVQYfrjxFyJD
L6tXrnVvlC6h1DJ76cHxCLlp8Mv80ReS6CtEJqJ81/yIAQvVryQRvpZXLv1Lfc6B
I1irPoyZIAAQNfdoNZ+JrMAtpQyXr+ifS3Lmbb7BSGIrSMVM8VYOPzUCa1Degxqc
Kt1jeNI3uxI+22hvjYnU4xhdAanhUroXsBC9nJ8oiwN8O7yYyNpMjDtEs+HigepW
SsC5VObQY3yOACH3PcccYJ9xorNivsecXbGOd+0xcl7tNbIEeVMugWPAncYp/kIk
Kwf/RPBvp05BgYLwppVdKL4Nzdr+8z3f+CvMV01lD5tGmvdC02mV+RwUXhAFu4Th
NNDKA3jd
=jxVI
-----END PGP SIGNATURE-----

Attachment: pgpEAY5li0dKV.pgp
Description: PGP signature


--- End Message ---
Reply to: