Bug#876726: apt-1.5/methods/http.cc: 3 * bad style comparisons ?

[Julian Andres Klode <jak@debian.org>]

Control: severity -1 minor

On Mon, Sep 25, 2017 at 10:14:27AM +0000, David Binderman wrote:
> Package: apt
> Version: 1.5
> 
> [apt-1.5/methods/http.cc:369]: (style) Comparison of a function returning boolean value using relational (<, >, <= or >=) operator.
> [apt-1.5/methods/http.cc:377]: (style) Comparison of a function returning boolean value using relational (<, >, <= or >=) operator.
> [apt-1.5/methods/http.cc:394]: (style) Comparison of a function returning boolean value using relational (<, >, <= or >=) operator.
> 
> The source code for the first one:
> 
>    while (Out.WriteSpace() > 0)

What did you check that with?

Anyway, it's true, but a minor cosmetic issue. It probably makes
sense to either change WriteSpace() to return the free space, or
to change the conditions to remove > 0.

-- 
Debian Developer - deb.li/jak | jak-linux.org - free software dev
                  |  Ubuntu Core Developer |
When replying, only quote what is necessary, and write each reply
directly below the part(s) it pertains to ('inline').  Thank you.