[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#796967: marked as done ([patch] backport to wheezy, need to drop APT_NORETURN)

Your message dated Mon, 3 Oct 2016 21:49:34 +0200
with message-id <20161003194934.swvzz2mqgnseri4v@crossbow>
and subject line Re: [patch] backport to wheezy, need to drop APT_NORETURN
has caused the Debian Bug report #796967,
regarding [patch] backport to wheezy, need to drop APT_NORETURN
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
796967: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=796967
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: apt-transport-tor
Version: 0.2.1-1
Severity: wishlist
Tags: patch

Hi.  I just tested to build this package on wheezy, and had to apply
this minor patch to get it building:

--- apt-transport-tor-0.2.1.orig/server.h
+++ apt-transport-tor-0.2.1/server.h
@@ -129,7 +129,7 @@ class ServerMethod : public pkgAcqMethod
    static std::string FailFile;
    static int FailFd;
    static time_t FailTime;
-   static APT_NORETURN void SigTerm(int);
+   static /* APT_NORETURN */ void SigTerm(int);
 
    virtual bool Configuration(std::string Message);
    virtual bool Flush() { return Server->Flush(File); };

Mentioning it here, in case someone else also want the package on
Wheezy.

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---
--- Begin Message --- 
Version: 0.3

On Wed, Aug 26, 2015 at 12:40:47PM +0200, Petter Reinholdtsen wrote:
> Hi.  I just tested to build this package on wheezy, and had to apply
> this minor patch to get it building:
[…]
> Mentioning it here, in case someone else also want the package on
> Wheezy.

This is "fixed" in 0.3 in sofar as you don't need a patch to build the
package basically anywhere – the problem is in its runtime dependencies
as a-t-tor doesn't built binaries anymore by requiring a fairly recent
apt version doing the heavy lifting instead.


It should be possible (as in: not exceptionally hard) to rip the
http/https code out of src:apt and embedded it again in a-t-tor for
a backport at which point you likely need this and/or other small
patches to backport them to earlier libapt-pkg versions.

That out-ripping could probably be automated and I see no problem with
collection backport-patches, I "just" want to avoid carrying outdated
embedded copies in official Debian release suites in the future.

It might long term be more reasonable to invest some resources in
getting apts "default" set of transports split into its own package
through instead of doing a-t-tor out-of-tree backports.


Anyway, as said, the patch isn't really applicable anymore, so closing
to not get people confused for now.


Best regards

David Kalnischkies

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: