[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#785337: "ResourceWarning: unclosed file" is emitted during the python unit tests phase of the build process



Control: tag -1 pending

On Fri, May 15, 2015 at 01:28:05AM +0200, von wrote:
> Package: python-apt
> Version: 0.9.4
> Severity: normal
> Tags: patch
> 
> During the python unit tests phase of the build process the following warning is emitted:
> 
> /usr/lib/python3.4/unittest/case.py:577: ResourceWarning: unclosed file <_io.TextIOWrapper name=66 mode='r' encoding='UTF-8'>
>   testMethod()
> 
> In tests/test_tagfile.py two files are opened and not closed. This is the reason of this warning.
> 
> The attached patch correct this problem.

Thanks for the patch, but it makes more sense to use the with statement
here. I fixed it in git.

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Be friendly, do not top-post, and follow RFC 1855 "Netiquette".
    - If you don't I might ignore you.


Reply to: