[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#785261: python-apt: Remove the "-Wstrict-prototypes" compiler option



Package: python-apt
Version: 0.9.4
Severity: normal
Tags: patch

The "-Wstrict-prototypes" compiler option is added by python distutils but this
option is not valid for C++. See See http://bugs.python.org/issue9031 and
http://bugs.python.org/issue1222585.

This result in 928 warnings of the form:
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++

The added patch solve the problem by removing the option via the setup.py script.
>From e733918b23d095a2ecdede4f647bd8f6f225aa7b Mon Sep 17 00:00:00 2001
From: von <mat_von@fastmail.fm>
Date: Thu, 14 May 2015 00:19:10 +0200
Subject: [PATCH] Remove the "-Wstrict-prototypes" compiler option, which isn't
 valid for C++. See http://bugs.python.org/issue9031 and
 http://bugs.python.org/issue1222585

---
 setup.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/setup.py b/setup.py
index 56f5c53..f9d5638 100644
--- a/setup.py
+++ b/setup.py
@@ -6,6 +6,7 @@ import os
 import sys
 
 from distutils.core import setup, Extension
+from distutils import sysconfig
 cmdclass = {}
 
 try:
@@ -54,6 +55,12 @@ if len(sys.argv) > 1 and sys.argv[1] == "build":
         import shutil
         shutil.copy(template, os.path.join("build", template))
 
+# Remove the "-Wstrict-prototypes" compiler option, which isn't valid for C++.
+# See http://bugs.python.org/issue9031 and http://bugs.python.org/issue1222585
+cfg_vars = sysconfig.get_config_vars()
+for key, value in cfg_vars.items():
+    if type(value) == str:
+        cfg_vars[key] = value.replace("-Wstrict-prototypes", "")
 
 setup(name="python-apt",
       description="Python bindings for APT",
-- 
2.1.4


Reply to: