Bug#781696: [PATCH] apt-key del keyid is case sensitive
On 04/09/2015 06:34 AM, David Kalnischkies wrote:
> Beahviour changes two seconds before release are no good.
I completely agree with this. Thank you for getting -qi into jessie.
I can file a separate bug tonight, and I guess close this one.
> Note that the output from gnupg as well as from apt is uppercase, so its
> likely that lowercase is only encountered if people interactively type
> out the keyids, which is not a very common usecase – after all apt-key
> is supposed to be used mainly by -keyring packages and even those are
> supposed to get away from using it leaving next to nobody with a valid
> usecase to use it…
There's a strong case that this was always wrong. At least a warning
should be given, but changing that is too late for jessie.
The interactive usecase is pretty common with third-party software
that distributes a key for their repo but not a keyring package.
> Please split up your patches into meaningful self-containt entities.
> Ignoring case is independent from erroring on not found for example,
> so that should be two commits, not bundled up in one.
Okay. Ignoring case is just one character of this patch (the i in
"-qi") but I see it should still be a separate commit.
>> msgtest "Try to remove a key which exists, but isn't in the"
'forced keyring'
>> testsuccess --nomsg aptkey --fakeroot --keyring
rootdir/etc/apt/trusted.gpg del DBAC8DAE
>
> Shouldn't (at least) this testcase fail if you fail on not acting?
In fact this test does fail. I didn't write it and it wasn't clearly
related to me so I didn't touch it.
Nathan
Reply to: