[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#746412: apt-get source linux behaves weird



Control: tag -1 - patch

> @@ -387,13 +388,15 @@ static pkgSrcRecords::Parser *FindSrc(const char *Name,pkgRecords &Recs,
>           // See if we need to look for a specific release tag
>           if (RelTag != "" && UserRequestedVerTag == "")
>           {
> -            const string Rel = GetReleaseForSourceRecord(SrcList, Parse);
> +            string Dist;
> +            const string Rel = GetReleaseForSourceRecord(SrcList, Parse, Dist);
>  
> -            if (Rel == RelTag)
> +            if (Rel == RelTag || Dist == RelTag)
>              {

In the experimental git branch this changed completely as Release files
have risen from the underground to be proper first class citizens (while
Sources are still second class at best) where this was fixed by
"accident" already in a seemingly "unrelated" commit (5ad0096a4) by me.


>                 Last = Parse;
>                 Offset = Parse->Offset();
>                 Version = Ver;
> +               break;
>              }
>           }
>  

That 'fixes' this problem while reopening #731853 among others. Running
the autopkgtest tests would have shown it. You can do this without
building and installing apt packages via ./test/integration/run-tests,
which will use the apt buildtree it is in. You need to install a bunch
of additional test-dependencies through.

Adding a testcase here (they are simple shell scripts with an insane
amount of shell functions building a testing 'framework' to setup
packages, repositories and webservers among others) wouldn't hurt the
acceptance of a patch either.


If you wanna work on this further feel free to find me at DebConf (if
you are here). I am the guy accompanied by super cow. Otherwise hit me
on IRC (DonKult) in #debian-apt or anywhere else. That extends to "all
the things apt" of course like bugs tagged newcomer… *hint hint*


Best regards

David Kalnischkies

Attachment: signature.asc
Description: Digital signature


Reply to: