--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: python-apt: Python 3.5 and PEP 479 support
- From: Barry Warsaw <barry@debian.org>
- Date: Thu, 16 Jul 2015 12:19:03 -0400
- Message-id: <20150716161903.20289.33191.reportbug@chemistry.wooz.org>
- Reply-to: Barry Warsaw <barry@debian.org>
Package: python-apt
Version: 1.0.0~beta3
Severity: normal
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Dear Maintainer,
PEP 479 in Python 3.5 clarifies the protocol for iterators when they
are exhausted, such that they should just 'return' rather than raise a
StopIteration. In fact, raising a StopIteration causes a silent
deprecation warning to be issued in Python 3.5. This results in
output to stderr, causing the DEP-8 tests of the package to fail.
Attached is a patch which just eliminates the explicit raising of
StopIteration and lets the iterators return by falling off the end of
the function. I've confirmed that the package builds, tests pass, and
DEP-8 tests pass with this patch.
- -- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.0.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages python-apt depends on:
ii libapt-inst1.5 1.0.9.10
ii libapt-pkg4.12 1.0.9.10
ii libc6 2.19-19
ii libgcc1 1:5.1.1-14
ii libstdc++6 5.1.1-14
ii python 2.7.9-1
ii python-apt-common 1.0.0~beta3
pn python:any <none>
Versions of packages python-apt recommends:
ii iso-codes 3.59-1
ii lsb-release 4.1+Debian13+nmu1
ii xz-utils 5.1.1alpha+20120614-2.1
Versions of packages python-apt suggests:
ii python-apt-dbg 1.0.0~beta3
pn python-apt-doc <none>
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVp9l1AAoJEBJutWOnSwa/zfoP/RNtYjQgY0G6RFcaEqpVZqPc
K/E5o9wEcPqj32/g0DCQZyXmzxhY7UWEu8cj2Woog9es6M3H+/5quBmBa4Rr/rk/
aWlUkv3CLkgEnfN71UX2MdRc34+Yg5Vx96+c1gDnC1bgQnHJ1YEIqElJr73aypf7
n1GgLp4IpXiFVLN5A9vKNEwfK6rBtXGwpX7WtcRd6R121YJfufTrBjdiNFVaUn77
utDOhygsG/kgr3BVfokrvd1ZX3BJwCBsDMNt1FrAer/y4qZq+CJeSTLmaFqG7rDr
G9Qo5Oj0mzekFvUmuA9kHWAELplfo4OkkOFmVHOolIfqfi5rdc+/8JcJtBOe1+QU
A9kqNjzZNaqFc+/T2RZJAsYpmhzoQlTLgAth94k4CcxdqKQxF9zgsu5iLuaRI03F
OxM3rL/reNVBAB47mu5UrEPadVsO+UvQxym+AuOz5hsAgKFaAX7ueTc4OwBUXqU/
hoQL1oL+1UW2hpfPIcjYWfGZod2rRLEO13EpigYiEDCd2Ptcs14gQ6MKoDwgAJBr
L+SkJwXdwAejGcgESSmZlvnQDyXSbx9n5buy9wqxY0cEMr2ixHJbR9Z244MRo+HP
Yyhb6VKPFf82u2bqoN7UAMIO1PWiKsXzmidySuwd8gBQPmcAAYemu+gXLMvIH7Vm
YxlKFob2spq0/rfbxuL2
=ASlQ
-----END PGP SIGNATURE-----
diff --git a/apt/cache.py b/apt/cache.py
index 74bbe71..7849806 100644
--- a/apt/cache.py
+++ b/apt/cache.py
@@ -221,7 +221,6 @@ class Cache(object):
# necessary for uncompressed indexes.
for pkgname in self.keys():
yield self[pkgname]
- raise StopIteration
def __is_real_pkg(self, rawpkg):
"""Check if the apt_pkg.Package provided is a real package."""
diff --git a/aptsources/sourceslist.py b/aptsources/sourceslist.py
index f490352..6be7e5e 100644
--- a/aptsources/sourceslist.py
+++ b/aptsources/sourceslist.py
@@ -295,7 +295,6 @@ class SourcesList(object):
types """
for entry in self.list:
yield entry
- raise StopIteration
def __find(self, *predicates, **attrs):
for source in self.list:
diff --git a/debian/changelog b/debian/changelog
index 2dc57e6..cbb3501 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+python-apt (1.0.0~beta4) UNRELEASED; urgency=medium
+
+ * To properly conform to PEP 479 and Python 3.5, __iter__() methods
+ should return when exhausted instead of raising StopIterator.
+
+ -- Barry Warsaw <barry@debian.org> Thu, 16 Jul 2015 11:37:43 -0400
+
python-apt (1.0.0~beta3) unstable; urgency=medium
* tests/test_paths.py: Catch and assert the DeprecationWarning
--- End Message ---
--- Begin Message ---
- To: 792606-close@bugs.debian.org
- Subject: Bug#792606: fixed in python-apt 1.0.0~beta3.1
- From: Michael Vogt <mvo@debian.org>
- Date: Tue, 04 Aug 2015 10:34:33 +0000
- Message-id: <E1ZMZYH-0004je-Mr@franck.debian.org>
Source: python-apt
Source-Version: 1.0.0~beta3.1
We believe that the bug you reported is fixed in the latest version of
python-apt, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 792606@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated python-apt package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Fri, 24 Jul 2015 17:51:25 +0200
Source: python-apt
Binary: python-apt python-apt-doc python-apt-dbg python-apt-dev python-apt-common python3-apt python3-apt-dbg
Architecture: source all amd64
Version: 1.0.0~beta3.1
Distribution: unstable
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Description:
python-apt - Python interface to libapt-pkg
python-apt-common - Python interface to libapt-pkg (locales)
python-apt-dbg - Python interface to libapt-pkg (debug extension)
python-apt-dev - Python interface to libapt-pkg (development files)
python-apt-doc - Python interface to libapt-pkg (API documentation)
python3-apt - Python 3 interface to libapt-pkg
python3-apt-dbg - Python 3 interface to libapt-pkg (debug extension)
Closes: 792606
Changes:
python-apt (1.0.0~beta3.1) unstable; urgency=medium
.
[ Michael Vogt ]
* fix py3 issue with auto .gz decompression and add test
* updated for the gcc5 transition
.
[ Julian Andres Klode ]
* doc/source/conf.py: Reproducibility: Set html_last_updated_fmt = None
.
[ Michael Schaller ]
* BaseDependency.__repr__: Replace pre_depend with rawtype
* apt/package.py: Add rawtype property to Dependency class
* Add dependency comparison (aka. relation) type in Debian notation
* apt/package.py: Add missing __str__ and __repr__ methods
* doc/source/library/apt_pkg.rst: Remove trailing whitespace
* apt_pkg.Dependency.all_targets: Fix the documentation
.
[ Barry Warsaw ]
* python-apt: Python 3.5 and PEP 479 support (Closes: #792606)
Checksums-Sha1:
4831c79c7615a5cd46cb0bcd9070859b136867e8 2283 python-apt_1.0.0~beta3.1.dsc
97faa4b39026d672147a5fbc76da00b8cecd8548 314092 python-apt_1.0.0~beta3.1.tar.xz
b1b72e12d9040604633e13ff0b564320d7be078b 91348 python-apt-common_1.0.0~beta3.1_all.deb
3d69f002045ab1cc57b4e2cff24b1645e1925730 1613260 python-apt-dbg_1.0.0~beta3.1_amd64.deb
4fa207c90b81b8b3f71bb795b9adf81f6761ec94 37398 python-apt-dev_1.0.0~beta3.1_all.deb
9efbe0c49398b097a95be9c5dcf6ccc82f353ce4 182260 python-apt-doc_1.0.0~beta3.1_all.deb
8e84229923ab9149f498fb9db79e065bdbc0a170 169172 python-apt_1.0.0~beta3.1_amd64.deb
ca26dc267bd6d4e5fd0b993620be6cab5c8e7540 1622040 python3-apt-dbg_1.0.0~beta3.1_amd64.deb
e93f5c43575d18d46608dc18c14fb2751aa3e05b 166158 python3-apt_1.0.0~beta3.1_amd64.deb
Checksums-Sha256:
756b500774fd0308fb13fbedd4b30ab3238da9238e2f66d947ccebf8a3af5155 2283 python-apt_1.0.0~beta3.1.dsc
e2ba7120d2b20caef187ddd697822a8dcaa612fb694d2cd1a9cacce52fd2a6cf 314092 python-apt_1.0.0~beta3.1.tar.xz
c3b4a03b7be5ba4723b4e5437c0d28dbab19416ef34590d0834814160afd5c5b 91348 python-apt-common_1.0.0~beta3.1_all.deb
29708a3b61bf2936c10ad5bf7edb1faa9807490563b8f2a69ccad74985846b89 1613260 python-apt-dbg_1.0.0~beta3.1_amd64.deb
018182d3691dfc0dc98c447abd6d5a239aaa1b86dcdb6f264379af374b027a28 37398 python-apt-dev_1.0.0~beta3.1_all.deb
5119988b5cf838f6e78c811df26b56d52c5a8f10ff57fb58d064b46e80b3f78e 182260 python-apt-doc_1.0.0~beta3.1_all.deb
36d6ce1d7be41fb42bcdb7242c4dd2e4a2454fef213a99022c13dba40a3caf0f 169172 python-apt_1.0.0~beta3.1_amd64.deb
04c183ffb2cd33ec6d1cc53a37ffa734ea3708011b2202a52a7c17ed4be22f02 1622040 python3-apt-dbg_1.0.0~beta3.1_amd64.deb
2eaefb0cb358da755de80213b2a2494962b801295a0c10e5ba10fc2d22e9a1d2 166158 python3-apt_1.0.0~beta3.1_amd64.deb
Files:
fc5299f140ca936b52bb2350b8f63cbb 2283 python standard python-apt_1.0.0~beta3.1.dsc
212c4b49b5560c46be062ebcaed1f2af 314092 python standard python-apt_1.0.0~beta3.1.tar.xz
b1caf5166e69c5f7ee1def0e141ae2b2 91348 python optional python-apt-common_1.0.0~beta3.1_all.deb
99567b1987337414d17e207fdbb22382 1613260 debug extra python-apt-dbg_1.0.0~beta3.1_amd64.deb
89a0d5add11635e510874c417cd8eb2d 37398 python optional python-apt-dev_1.0.0~beta3.1_all.deb
d6bbde9a04e47a2f249aeb2490796d05 182260 doc optional python-apt-doc_1.0.0~beta3.1_all.deb
cd13c441f90f7449086be5f8e867e395 169172 python standard python-apt_1.0.0~beta3.1_amd64.deb
13ff13aba73f4617fd9c7dd966442e63 1622040 debug extra python3-apt-dbg_1.0.0~beta3.1_amd64.deb
5b9b2d193c6d4476f26e297f453bbdc2 166158 python optional python3-apt_1.0.0~beta3.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVwJFfAAoJEL1+qmB3j6b1r8kQAL2OZxS497if17+hUEUM7FZz
5LQJFEPH3ICVCo+oa4ZM76HILOo/0gseXlu9SGkY2SXDV0BhwRD4fGPpErIti522
uXx7pD8IGEU6+ExA5y9yiOJjo/tTQMdTIqc23yaMA09PEWihV/NyFifltRoE33+e
al1AFYlssssdRhln/7lPihtu8wllLt1KhsAPTRCwDIfyKI1xj2gXL8uynWchXqVG
YQckDAurjEgHpDhX4OH4xEUdITq+LdjoCFHoGTjBPS2vnozFcsiekoDkQDmh08Tw
jNWwqBv2Eb2BNta0kpW9eaJzig647eRgBjBKpzTJwv3CqA1ZkNZkd4zcnISfIdKn
peNLoHgULdQ5tZ1zemWGF6O6xxt0tjyjDerp//kezi6uUevTeNj4ff0Yyr2b1f55
jdIVV7Ny1viNFl8gFmXAews5U9d08nicDEA7k6upXUOOKptsyUIslIlzqNwE12a+
sL+10gm/VEob9zfvYgHrwg1xkqlLCwaYZH9TJLgFCU6uZIluabMxXQRYX9GfSEfO
gyI0BiQjh/B7V4oyDov2F9BNWH/uKtukCL/OKP6WZJGL1QoSQJtcN3yIU1UJspj4
L+5Af1gcs0XBhxj5iqbyjNic56lexWjxkvd/+zotjrcCX0Y5xFBprLMYvTBBWgjt
GM7+rVq7Mym6VDsPccKq
=+JtR
-----END PGP SIGNATURE-----
--- End Message ---