[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#792606: python-apt: Python 3.5 and PEP 479 support



On Thu, Jul 16, 2015 at 12:19:03PM -0400, Barry Warsaw wrote:
> Package: python-apt
> Version: 1.0.0~beta3
> Severity: normal
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Dear Maintainer,
> 
> PEP 479 in Python 3.5 clarifies the protocol for iterators when they
> are exhausted, such that they should just 'return' rather than raise a
> StopIteration.  In fact, raising a StopIteration causes a silent
> deprecation warning to be issued in Python 3.5.  This results in
> output to stderr, causing the DEP-8 tests of the package to fail.
> 
> Attached is a patch which just eliminates the explicit raising of
> StopIteration and lets the iterators return by falling off the end of
> the function.  I've confirmed that the package builds, tests pass, and
> DEP-8 tests pass with this patch. 

Thanks for the patch, I merged it.

It would be nice if you could provide a proper git patch the next
time, with a commit message and without changes to debian/changelog.

I manually reconstructed a proper commit message, but apparently
messed things up a bit, by including "python-apt: " in the summary :(

The commit is

http://anonscm.debian.org/cgit/apt/python-apt.git/commit/?id=92e2da6e69164c8311b7f33f800f2dc594629c5d


Thanks,

Julian

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Be friendly, do not top-post, and follow RFC 1855 "Netiquette".
    - If you don't I might ignore you.


Reply to: