[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762674: marked as done (python-apt: please don't embed the date and time of the build in apt_pkg)

Your message dated Fri, 24 Oct 2014 15:42:45 +0000
with message-id <E1Xhh0n-0000L1-FH@franck.debian.org>
and subject line Bug#762674: fixed in python-apt 0.9.3.11
has caused the Debian Bug report #762674,
regarding python-apt: please don't embed the date and time of the build in apt_pkg
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
762674: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762674
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: python-apt
Version: 0.9.3.10
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps

Hi!

As part of the “reproducible builds” projects [1], we have discovered
that the apt_pkg module provided by python-apt embeds the date and time
of the build. This makes the build process unreproducible.

We don't believe such timestamps to be useful. In the case of apt_pkg,
it's even a little bit confusing because the values of VERSION and
LIB_VERSION are actually coming from apt, but DATE and TIME will depend
solely on the build time of python-apt.

The attached patch simply removes the DATE and TIME apt_pkg members.
This is the only modification needed to make the package build
reproducible. The sole known user of these members in the Debian archive
in the example script in python-apt, according to codesearch:
http://codesearch.debian.net/search?q=apt_pkg\.DATE
http://codesearch.debian.net/search?q=apt_pkg\.TIME

If the API change is not acceptable, another solution would be to
generate their value from the latest entry of debian/changelog.

 [1]: https://wiki.debian.org/ReproducibleBuilds

-- 
Lunar                                .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

diff -Nru python-apt-0.9.3.10/debian/changelog python-apt-0.9.3.10.0reproducible1/debian/changelog
--- python-apt-0.9.3.10/debian/changelog	2014-09-04 18:08:55.000000000 +0200
+++ python-apt-0.9.3.10.0reproducible1/debian/changelog	2014-09-24 12:09:21.000000000 +0200
@@ -1,3 +1,10 @@
+python-apt (0.9.3.10.0reproducible1) UNRELEASED; urgency=medium
+
+  * Stop providing apt_pkg.DATE and apt_pkg.TIME as they make the build
+    unreproducible.
+
+ -- Jérémy Bobbio <lunar@debian.org>  Wed, 24 Sep 2014 10:08:36 +0000
+
 python-apt (0.9.3.10) unstable; urgency=medium
 
   * python/tag.cc: ensure that the final \n is there when 
diff -Nru python-apt-0.9.3.10/python/apt_pkgmodule.cc python-apt-0.9.3.10.0reproducible1/python/apt_pkgmodule.cc
--- python-apt-0.9.3.10/python/apt_pkgmodule.cc	2014-09-04 18:08:55.000000000 +0200
+++ python-apt-0.9.3.10.0reproducible1/python/apt_pkgmodule.cc	2014-09-24 12:08:34.000000000 +0200
@@ -880,8 +880,6 @@
    // Version..
    PyModule_AddStringConstant(Module,"VERSION",(char *)pkgVersion);
    PyModule_AddStringConstant(Module,"LIB_VERSION",(char *)pkgLibVersion);
-   PyModule_AddStringConstant(Module,"DATE",__DATE__);
-   PyModule_AddStringConstant(Module,"TIME",__TIME__);
 
    // My constants
    PyModule_AddIntConstant(Module,"PRI_IMPORTANT",pkgCache::State::Important);
diff -Nru python-apt-0.9.3.10/doc/examples/config.py python-apt-0.9.3.10.0reproducible1/doc/examples/config.py
--- python-apt-0.9.3.10/doc/examples/config.py	2014-09-04 16:08:55.000000000 +0000
+++ python-apt-0.9.3.10.0reproducible1/doc/examples/config.py	2014-09-24 10:21:34.000000000 +0000
@@ -45,8 +45,7 @@
     print "Version selected - 1.1"
 
 if Cnf.find_b("help", 0) == 1:
-    print "python-apt", apt_pkg.VERSION, \
-          "compiled on", apt_pkg.DATE, apt_pkg.TIME
+    print "python-apt", apt_pkg.VERSION
     print "Hi, I am the help text for this program"
     sys.exit(0)

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: python-apt
Source-Version: 0.9.3.11

We believe that the bug you reported is fixed in the latest version of
python-apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 762674@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated python-apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 24 Oct 2014 10:16:01 -0400
Source: python-apt
Binary: python-apt python-apt-doc python-apt-dbg python-apt-dev python-apt-common python3-apt python3-apt-dbg
Architecture: source amd64 all
Version: 0.9.3.11
Distribution: unstable
Urgency: low
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Description:
 python-apt - Python interface to libapt-pkg
 python-apt-common - Python interface to libapt-pkg (locales)
 python-apt-dbg - Python interface to libapt-pkg (debug extension)
 python-apt-dev - Python interface to libapt-pkg (development files)
 python-apt-doc - Python interface to libapt-pkg (API documentation)
 python3-apt - Python 3 interface to libapt-pkg
 python3-apt-dbg - Python 3 interface to libapt-pkg (debug extension)
Closes: 762674
Changes:
 python-apt (0.9.3.11) unstable; urgency=low
 .
   [ Colin Watson ]
   * Add template for the "Ubuntu-RTM" derived distribution.
   * Detect whether a system is running Ubuntu-RTM by way of
     "system-image-cli -i".  Not perfect but close enough.
 .
   [ Julian Andres Klode ]
   * Embed changelog entry date and time instead of build date and time
     (Closes: #762674)
 .
   [ Michael Vogt ]
   * python/tarfile.cc: use long long in Process() for APT >= 4.14
   * Merged UbuntuRTMDistribution detection from ubuntu
   * Add Ubuntu 15.04 (Vivid Vervet) to the template
Checksums-Sha1:
 102461bf42d82494bc5623dce59bc810350a5ff8 2234 python-apt_0.9.3.11.dsc
 bfaade117156836404bf3adda6a5ff8b007df11f 307972 python-apt_0.9.3.11.tar.xz
 85d6be0167bf0487865f1cfc88866b4737e2e827 170554 python-apt_0.9.3.11_amd64.deb
 3c8bda21cc251aefd6e4beedb1ed2263d98cd0ff 154962 python-apt-doc_0.9.3.11_all.deb
 3a76dc0074a7ae248333f294588aa815d3d7f18d 1567920 python-apt-dbg_0.9.3.11_amd64.deb
 aa3578ad5124890885451db48c992d8d6e8118bd 7528 python-apt-dev_0.9.3.11_all.deb
 84e05ada5112fa3d28b615e7e190affbc797d86c 90292 python-apt-common_0.9.3.11_all.deb
 d4210a94b3e0205dd8e60913febaed53defc0c68 168472 python3-apt_0.9.3.11_amd64.deb
 292e4107be8bdada470777038bc711f758b9f4a7 1576032 python3-apt-dbg_0.9.3.11_amd64.deb
Checksums-Sha256:
 8e88f2ef9690cc93786caeaf0180eb2ac1f861b40a16c429a63dc5da6ead3126 2234 python-apt_0.9.3.11.dsc
 33d9fd106f0f2bbcdf49711a198d196bf6624ed335eec856c278ff73ca2e5fc9 307972 python-apt_0.9.3.11.tar.xz
 288bff871bf6de64ec069f5c1e115a404ae4ccce1afb453c6cf6bbe443fd00f8 170554 python-apt_0.9.3.11_amd64.deb
 47df778c214ff8695f41be09f058d71e2b403fde199c3051955468c361ecd471 154962 python-apt-doc_0.9.3.11_all.deb
 0e817ab9373ba1bd76a59e1340dc06a3c7b140c235982213518c79e5bed0ff40 1567920 python-apt-dbg_0.9.3.11_amd64.deb
 a6fc5a51594f066fd587694ec78cc69f0af602639acbd0603fe532cad75cf255 7528 python-apt-dev_0.9.3.11_all.deb
 104bf8915605c6a100b3bf010cad7d494b3580188133b6b83fa454e4e87f46fe 90292 python-apt-common_0.9.3.11_all.deb
 983132450739ce1fe6b9f01e5f74d0b0f800eb3825c21419c173960e1bda756c 168472 python3-apt_0.9.3.11_amd64.deb
 d1681be562f255e5dd543e6f0cdc95f6a43792baa1376e70ed2c16a4f65c342c 1576032 python3-apt-dbg_0.9.3.11_amd64.deb
Files:
 60f0c93add882632c7aff079b44d5b41 2234 python standard python-apt_0.9.3.11.dsc
 eeb4b6c1fb7c9da635cd0fd18b8bff9c 307972 python standard python-apt_0.9.3.11.tar.xz
 a411a955ac2ab20aeab6aadcbe678ed4 170554 python standard python-apt_0.9.3.11_amd64.deb
 5165995d81986274ea356f26f3c85399 154962 doc optional python-apt-doc_0.9.3.11_all.deb
 5df612b3b392763e08c586f9cdeb9d4f 1567920 debug extra python-apt-dbg_0.9.3.11_amd64.deb
 fe63b7322955d3fca2ce16076e99fabf 7528 python optional python-apt-dev_0.9.3.11_all.deb
 c16b379e26b47e986f2d8143e8d87cda 90292 python optional python-apt-common_0.9.3.11_all.deb
 d4a5d4b89e1adbf741e91475c2c713ee 168472 python optional python3-apt_0.9.3.11_amd64.deb
 0691eb84250f317a23f7912ca7a828c5 1576032 debug extra python3-apt-dbg_0.9.3.11_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUSmH9AAoJEJjKuzq9TKWeMkMQAMI1OIRvKClOINvFFr8kWlsr
Uz0Lgu5kjzA4jWQD1B21UhfqFncrJNIJgEgtcUpzsi6xtbXIremp8IXhaAkbWsom
y4UeCCi//2Oexrah/OGJVaLHBh/XQ3fMIOAhZ46IZdBei4sBWxFB2/d5/wxsbtXq
3smUQ83o+4yxhJr2OI8yAP2nrd2VyBftAdAMOSsTEHTr+mS3FuAzHi8xDfEfgdFn
bjKWH/S0jc46y9bYYICuiM/0mQnLu2HBQJMUZOPOYR/8WmFYi20xXHFU3mG0YRs4
+BxiHM1GsjbQU8Pc9otjiHf5fW4eRK11AFTu71PIDqNHwyWHwQZZ10B+tKX8mVtS
DdkWtmqXzIDdftMvrta+TJ83MZOoM+CQbhiX2w+BCDcg2MymBVnPycW3vJWJNCLX
PMzDAnMlTIVoF+aPJJ1xOgTMuOLK5Hvczi/vGYW2R27IGXcXakx2BFQ4eFR4WCWi
YLgMt7dxOul8PqlWi5gMPqoANpNh+6THZ++xse+Bowrg1fhA3IKXaHklTgFpHAf4
jZJUWSEjjIx7jXFao3eJGckO1RHN4JGIQSDCzdwBWSPeVESQ0bPi/qDxH3DRV0WF
WHmkG+w3UydGSGXSXkC17gH6heywRlR9wUZYclFzzu6Ncnqyf9PLZdDuDujSttoh
GhXbHLuQLizoUtymy4A5
=K7FB
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: