[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#686221: marked as done (libapt-pkg4.12: vci::FromString can not be reused with alternate pci::FromString)

Your message dated Wed, 08 Oct 2014 11:00:07 +0000
with message-id <E1XboyV-0003mc-VD@franck.debian.org>
and subject line Bug#686221: fixed in apt 1.1~exp4
has caused the Debian Bug report #686221,
regarding libapt-pkg4.12: vci::FromString can not be reused with alternate pci::FromString
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
686221: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686221
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libapt-pkg4.12
Version: 0.9.7.4
Severity: wishlist

Dear Maintainer,

The pci, vci constructors (FromString, FromRegex, etc.) are currently
static members.  When vci::FromString seeks to find which packages to
use it calls pci::FromString and there is currently no way to tell vci
to use a different pci constructor.

In the example of aptitude, we would like to replace pci::FromString
so that it uses “FromPattern” instead of FromRegex.  This means we
would have to also reimplement (i.e. copy-paste) vci::FromString to
use the new pci::FromString.

One way around this is to use virtual constructors on pci and vci.  I
suspect this then requires aptitude to define it's own PackageSet,
etc. which derives from aptitude::pci and pkgCache::PackageSet.  This
is also a fairly disruptive change to the current cache set design.

Perhaps a better solution, without the need to create derived
interface and container classes, is to use CacheSetHelper to redirect
to the appropriate constructor.  Something like:

-- cacheset.cc:
 virtual bool CacheSetHelper::PackagesFromString(pci, Cache, string)
 { return PackageContainerInterface::FromString(pci, Cache, string, *this); }

 bool VersionContainerInterface::FromString(…) {
 …
 PackageSet pkgset;
 if (onlyFromName == false)
   helper.PackagesFromString(&pkgset, Cache, pkg, helper);
--

Something like that could also be used when matching arch so that the
helper instance defines the policy for whether wildcards return all
matches or not.  See #686220.

Anyway, I plan to investigate these and maybe other options.  Filing
here in case anyone has any thoughts on this.

Regards

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Foreign Architectures: amd64

Kernel: Linux 2.6.32-5-686-bigmem (SMP w/1 CPU core)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libapt-pkg4.12 depends on:
ii  libbz2-1.0         1.0.6-1
ii  libc6              2.13-34
ii  libgcc1            1:4.7.1-2
ii  libstdc++6         4.7.1-2
ii  multiarch-support  2.13-26
ii  zlib1g             1:1.2.7.dfsg-13

libapt-pkg4.12 recommends no packages.

libapt-pkg4.12 suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: apt
Source-Version: 1.1~exp4

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 686221@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@ubuntu.com> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 08 Oct 2014 09:37:35 +0200
Source: apt
Binary: apt libapt-pkg4.14 libapt-inst1.6 apt-doc libapt-pkg-dev libapt-pkg-doc apt-utils apt-transport-https
Architecture: source all amd64
Version: 1.1~exp4
Distribution: experimental
Urgency: medium
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@ubuntu.com>
Description:
 apt        - commandline package manager
 apt-doc    - documentation for APT
 apt-transport-https - https download transport for APT
 apt-utils  - package management related utility programs
 libapt-inst1.6 - deb package format runtime library
 libapt-pkg-dev - development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - documentation for APT development
 libapt-pkg4.14 - package management runtime library
Closes: 647001 686221 733028 754436 762889 762898 763004 763033 763379 764055 764066
Changes:
 apt (1.1~exp4) experimental; urgency=medium
 .
   [ Michael Vogt ]
   * Merge sid version 1.0.9.2
   * feature/acq-trans:
     - Make apt-get update more transactional by keeping all data from
       a sources.list line in partial/ until all data is good and only
       then move it into lists/ in one step
     - add new -o Debug::Acquire::Transaction=1 debug option
   * feature/expected-size:
     Do not download more data in the mehotds than expected if we know
     the size. For the InRelease/Release/Release.gpg add new
     Acquire::MaxReleaseFileSize that defaults to 10Mb for now
   * Verify the the hashes of the downloaded compressed files early
   * Only load unauthenticated data into our parsers when the user
     explicitly asked for it via --allow-insecure-repositories
     (Acquire::AllowInsecureRepositories)
   * Print warning when trying to use unauthenticated repositories
   * Use /var/empty as the homedir for _apt
   * Revert making pkgAcquire::Item::DescURI() "const" to not break
     API
   * Do not allow going from a authenticated to unauthenticated repository
   * Add missing "adduser" dependency (for the new _apt user)
     Thanks to Russ Allbery (Closes: #763004)
   * Test if TMPDIR is a directory in apt-key and if not unset it
   * add early verification for the .diff/Index download
   * Bump library version to libapt-pkg4.14
   * Rework pkgAcqMeta{Index,Sig,ClearSig}::{Done,Failed]() for readability
   * Ignore EINVAL from prctl(PR_SET_NO_NEW_PRIVS) (closes: 764066)
 .
   [ David Kalnischkies ]
   * deprecate Pkg->Name in favor of Grp->Name
   * drop stored StringItems in favor of in-memory mappings
   * de-duplicate version strings in the cache
   * fix progress output for (dist-)upgrade calculation
   * move PCI::From* methods into CacheSetHelper class (Closes: 686221)
   * add a (hidden) --quiet option for apt-key
   * only create new trusted.gpg if directory is writeable
   * support (multiple) arguments properly in apt-key
   * set a primary-keyring only if we have access to it
   * merge fragment keyrings in apt-key to avoid hitting gpg limits
     (Closes: 733028)
   * use apt-key adv (+ gnupg) instead of gpgv for verify
   * support gnupg2 as drop-in replacement for gnupg
   * allow to specify fingerprints in 'apt-key del'
   * use only one --keyring in gpg interactions
   * add and use 'apt-key verify' which prefers gpgv over gpg
   * remove empty keyrings in trusted.gpg.d on upgrade
   * store source name and version in binary cache
   * allow fetcher setup without directory creation (Closes: 762898)
   * cleanup partial directory of lists in apt-get clean (Closes: #762889)
   * allow options between command and -- on commandline
   * update symbols file
   * support parsing of all hashes for pdiff
   * ensure world-readability for trusted.gpg in postinst (Closes: 647001)
   * ensure partial dirs are 0700 and owned by _apt:root
   * use _apt:root only for partial directories
   * display errortext for all Err
   * set PR_SET_NO_NEW_PRIVS also if run as non-root
 .
   [ James McCoy ]
   * ensure apt-key del handles 16-byte key ids (Closes: 754436)
 .
   [ Kenshi Muto ]
   * Japanese program translation update (Closes: 763033)
 .
   [ Trần Ngọc Quân ]
   * Set STRIP_FROM_PATH for doxygen
 .
   [ Mert Dirik ]
   * Turkish program translation update (Closes: 763379)
 .
   [ Guillem Jover ]
   * apt-get: Create the temporary downloaded changelog inside tmpdir
 .
   [ Miroslav Kure ]
   * [l10n] Updated Czech translation of apt (Closes: #764055)
Checksums-Sha1:
 94e9dc7f0ff5d8e6b43cf62ddafe416ab9c16f64 2357 apt_1.1~exp4.dsc
 35b3355e4fa6f4c13fdbb234a6520817799f1495 1824432 apt_1.1~exp4.tar.xz
 c60da50e75d44b3ae684b18562b516da5344ecc1 302332 apt-doc_1.1~exp4_all.deb
 96be7087c8fa3169e953961a46af025ed4ad907f 859900 libapt-pkg-doc_1.1~exp4_all.deb
 135d59429a8315f9098301d022535b48ce204a82 804034 libapt-pkg4.14_1.1~exp4_amd64.deb
 01c4dd671b9cb7e0fd266ced320b6d668fe5245f 170452 libapt-inst1.6_1.1~exp4_amd64.deb
 6345ef48080c84c77b9980c11eab92f20566b346 1105576 apt_1.1~exp4_amd64.deb
 9ce2edfb76b543b628ef466a782bcda56e9f8162 199334 libapt-pkg-dev_1.1~exp4_amd64.deb
 e6fce60187a0af81cfba4b6a4332a6daeba255b8 370724 apt-utils_1.1~exp4_amd64.deb
 3e3a472d93dfe9dd8e83c8feeef02a82a27fa807 138784 apt-transport-https_1.1~exp4_amd64.deb
Checksums-Sha256:
 4b4f00eeb0562d64d4727927e0ef35c75ff63e9672ea7144b88caf92a41d9208 2357 apt_1.1~exp4.dsc
 edbb52e5fae376194def49b3edef3b51fb4aa043493c1e94eeeff1c2cad429c7 1824432 apt_1.1~exp4.tar.xz
 f1e0f97fa1a9a6b00a75edbaa877f24d9c90611aa6a5522e87304fb0c94e8b98 302332 apt-doc_1.1~exp4_all.deb
 57aa542a6b957369bcdfda186aec581b0eff20e3b0ecef86c0cc2e7a3e139a10 859900 libapt-pkg-doc_1.1~exp4_all.deb
 25663802aa4bfa2246fe385679ca6558a9dfb430eedd38ddf40392ed457d00dd 804034 libapt-pkg4.14_1.1~exp4_amd64.deb
 5a55287e6ad900050a246293ec8c2a843d60b6e583fc0850fe6a3210cc84fd39 170452 libapt-inst1.6_1.1~exp4_amd64.deb
 dc976e9118e07b97b768a5ad22712f5825d6564f3bf3c2206807afd4ef73c346 1105576 apt_1.1~exp4_amd64.deb
 1c9ee7b618bcf8efeb3f40bad4e4cade143709dab35b8967193ed5fed0ddb0d0 199334 libapt-pkg-dev_1.1~exp4_amd64.deb
 661ad0f64f3950421baf59b6e4136edf1ed1e5612e9972cc563c87832cfd6975 370724 apt-utils_1.1~exp4_amd64.deb
 8aac0f89a15e9a08ce9c6b02e356ee73034b77bab51578cd4457430ea7e7edb3 138784 apt-transport-https_1.1~exp4_amd64.deb
Files:
 f5096e0f107df56fae947b5296a6bd27 2357 admin important apt_1.1~exp4.dsc
 ce7bf46f6ae580ab1dbc223f06dbd811 1824432 admin important apt_1.1~exp4.tar.xz
 e204ab933990236e67b3eda430f9bbec 302332 doc optional apt-doc_1.1~exp4_all.deb
 72367b2cfcc3069708180fa01a4075ed 859900 doc optional libapt-pkg-doc_1.1~exp4_all.deb
 b1a393c98af4ca150ecc7c72edb5ca72 804034 libs important libapt-pkg4.14_1.1~exp4_amd64.deb
 fa42e776db6ba5cdda6985c6a48d2eb6 170452 libs important libapt-inst1.6_1.1~exp4_amd64.deb
 da64e619525d6aacda53dadb3cac51df 1105576 admin important apt_1.1~exp4_amd64.deb
 f02fd73daddae42c5b2bf8f73b86ac5e 199334 libdevel optional libapt-pkg-dev_1.1~exp4_amd64.deb
 ae2931e63117648ea20aca17cc90f5dd 370724 admin important apt-utils_1.1~exp4_amd64.deb
 2cc88efed3428b753fd36aec6bb325d4 138784 admin optional apt-transport-https_1.1~exp4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUNO4WAAoJEJjKuzq9TKWey/IQAOuc+uegxVa0tsWCIHxJqTYN
7QzsLv/D3yJyuDjPzgUP1Lt4xsoq0hJq4hlhRDDYxPeXJuNHuga5UZTh0ysZUlRh
dHd4EbR5YsYR/oNWr7jpIGhYJOOwVhurPGkZJm82A6JKvXxHwk/Fq2nA3XItZ4u/
YDHCj3oS7ZI4Kfx0N3249RbCIPGCFvQpudPcR6X+tYsaGCJPS1PZGkLp4n+j7Q1v
5KYU4F3HPpInT4QN9/kTFnw9fKwDXb0T+DOo5dhODiS4MDIzE3b1Os4EtGtDvecP
eEuj8Ag3IDmXNNSIGumzAMGNy8/cY125t6ZhMDd43aVitK6YqORF3g4gmCe4cHHS
a+nxjim4Y0iPA+2gF6qwt0v2agyB52dyRxUBgxnBopc/5kMI2P2rV+tIRCWaPCb9
fDLVSz+F9/RhYLFOrfcRqPSpsq+Ej2aACZsKiw8ZlDo9jcbtgyMbG4VpDSJOE0dS
rpvXg5ZVI74OZJ3FrKd20mtPSn/t/QzP7DhV8yVS/XnswdJlDqQnpUQ0RFt6tMr7
IaPjIug0JFo6EnRCIwc4z/eWrCTUat1jUWt7e6rWTVeMnCrq+/aq8WnHKoRM7acw
bMR+lEmuubnhENGVr6F8dc8dKay2puslX1Im82sVpL8e4BwF7XIT6egIVDUQxVnQ
rYEbfRlZW6bwOGft7UH2
=Apvx
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: