[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#742611: apt-cache: showsrc non-existent returning 0



Hello,

On Tue, Sep 23, 2014 at 04:45:47PM +0200, Maximiliano Curia wrote:
> El 2014-03-26 a las 16:38 +0100, David Kalnischkies escribió:
> > So while this would make sense, we hadn't the energy to push this hard
> > enough. I guess a plan would be to:
> > 1. add an option (default disabled) to promote them to errors again
> >    ( -o apt::some::thing=true/false can be added at will )
> > 2. change sbuild, launchpad, … to use this option if needed
> > 3. change the default of the option to enabled
> > 4. add the option to all the software forgotten in 2.
> 
> > I would accept a patch for 1. in jessie, so that if all known things in
> > 2. can get fixed (one way or the other) to cope with 3. in jessie+1, but
> > that needs someone who wants to work on it… volunteers?
> 
> I've prepared another patch that adds the config option.
> 
> Care to review it?

Thanks for picking it up & sorry, I meant to reply earlier…


> commit 333644f0f6651b0e8201d8583855f4b5b19c5242
> Author: Maximiliano Curia <maxy@debian.org>
> Date:   Tue Sep 23 15:17:34 2014 +0200
>
>     apt-cache showsrc non-existent return code
>
>     Raise the message to error, and exit with a return code !=0 to make scripting
>     easier. This functionality is disabled by default and depends on the
>     APT::Cache::ShowSrcErrorOnNotFound configuration option, or the
>     --error-on-not-found command line option to showsrc.

I guess for uniformity the config option should be named
"APT::Cache::ShowSrc::ErrorOnNotFound" as it is written as an option
specific to showsrc.

I would be more happy if it would be a more general option and in fact
"reverts" cd7bbc479f8e2f277092a9557bb486ab664deba6.  Although, now that
I am looking, this commit actually doesn't include showsrc as CacheSets
are limited to binary packages/versions.

Anyway, a new option should really have some documentation, aka
a sentence or two in doc/apt-cache.8.xml.


Best regards

David Kalnischkies

Attachment: signature.asc
Description: Digital signature


Reply to: