Re: [PATCH 2/2] private-output: remove superfluous line breaks in ListSingleVersion()
Hello David,
On 29.08.2014 12:42, David Kalnischkies wrote:
> You seem to have a usecase, and we are always interested in collecting
> them in our testcases so we don't break them (too often ;) ). It would
> therefore be fabulous if you could add one you can take inspiration
> from/add it to test/integration/test-apt-cli-list and include it in your
> patch. As you will see, they are simple shellscripts, so I hope you can
> manage, otherwise just describe your usecase some more so we can create
> one together.
no problem, I'll add my test cases and send a v2 for patch 2/2. You may
want to apply patch 1/2 in the meantime to fix the regression.
One thing tough: test-apt-cli-list contains a test case for
"--all-versions", which I suppose is equal to -o
APT::Cmd::All-Versions=true. Unfortunately this test case only lists one
package name, so it's unclear which of these two possible outputs would
be correct for two packages:
A) (current)
Listing...
foobar/unstable 2.0 i386 [upgradable from: 1.0]
foobar/now 1.0 i386 [installed,upgradable to: 2.0]
another/unstable 1.0 i386 [...]
B)
Listing...
foobar/unstable 2.0 i386 [upgradable from: 1.0]
foobar/now 1.0 i386 [installed,upgradable to: 2.0]
another/unstable 1.0 i386 [...]
> Running the tests could have caught the previous issue btw, so I am
> raising my pointy finger in strong disapproval against Michael, as he
> made our tests fail… you filthy bad boy! :P
I take the blame for that, as I was too lazy to figure out how to run
the tests in the first place. ;-)
Regards,
Andreas
Reply to: