Bug#742611: apt-cache: showsrc non-existent returning 0
Package: apt
Version: 0.9.16.1
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
apt-cache showsrc non-existent shows a W and a N message and returns 0, while
apt-cache show non-existent shows a W and an E message and returns 100.
The show approach makes it easier for scripts that rely on apt-cache, so I'm
attaching a simple patch for showsrc for this.
Thanks,
- -- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.14-rc7-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages apt depends on:
ii debian-archive-keyring 2012.4
ii gnupg 1.4.16-1.1
ii libapt-pkg4.12 0.9.16.1
ii libc6 2.18-4
ii libgcc1 1:4.8.2-17
ii libstdc++6 4.8.2-17
apt recommends no packages.
Versions of packages apt suggests:
ii apt-doc 0.9.16.1
ii aptitude 0.6.10-1
ii dpkg-dev 1.17.6
ii python-apt 0.9.3.4
ii synaptic 0.81
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJTMYU5AAoJEMcZdpmymyMqWwQP/Rkg4Jz3PtBWE+fjVrntnpdf
jar+BGAaZV54vGMI+YCjBv+yXNXedO3pJgNQXnxyPW0bezB4cVv1hCoX5fpv7d7e
kYzc0KyLnTwMqqYBcr+MB8ayvLxdsm9WDgo+rh4TgWKRBlaNp2MViHvMRSjCcE2i
FC1FrslWHKkAAWSpga902rjhxdp3+nmHLhRbMrEO1UrgCYPn4AKl6/Q8FZoMkrEV
jA6QJQ9csl3wBljkoXdh+FSxyKLlmZURrQr57mO4YzJ0XVj8IgCZrGL77q87MJlC
FTwSNXunh0ubPp4DVUNeFJ9dX798e5C8rCPfMKROli11NhbTNJuFyEE9nEJKFUPr
lBk+xjW0u+zC0gIIhjYiKRqFEGSL6uUO6RmZqkTV8st0ZitnQF7NlQNC7nyiLesS
gpvSVpqKmnRY5YIGaoUswmSUdZvH7uVe8gdLeFlP3L3k7Hm/ZtqQREesXvO0IfSr
7n6Ul5SJYwv7o+Z0peCQqELUdXA5viNprMTOLeILCNsCedOP0YwYPnkNl/78Uidb
FogRc1wRa9Gv1XFUjwSjHOQ1uKH4gt1ZzAvlVknfcNR6kWyJ7wt2BRxzqOCx27zP
d9vYLq57MIT0EfYS7M7ug+/y6qCQuhAki5i5szoTqOC637K7AQtAEMdwPZWT+mdi
AgL9Ls+Gv4hfO/GqK9jQ
=8HFg
-----END PGP SIGNATURE-----
commit cb67f44517d3861b24706fd7a122fe2f696e9090
Author: Maximiliano Curia <maxy@gnuservers.com.ar>
Date: Tue Mar 25 14:16:28 2014 +0100
apt-cache showsrc non-existent return code
Raise the message to error, and exit with a return code !=0
to make scripting easier.
diff --git a/cmdline/apt-cache.cc b/cmdline/apt-cache.cc
index 84b7753..97d01f4 100644
--- a/cmdline/apt-cache.cc
+++ b/cmdline/apt-cache.cc
@@ -1517,7 +1517,7 @@ static bool ShowSrcPackage(CommandLine &CmdL)
}
}
if (found == 0)
- _error->Notice(_("No packages found"));
+ return _error->Error(_("No packages found"));
return true;
}
/*}}}*/
Reply to: