Bug#768797: HTTP method parser gets into wrong state upon 416 reply with Content-Length > 0
On Sun, Nov 9, 2014 at 6:51 PM, David Kalnischkies
<david@kalnischkies.de> wrote:
> Hi,
>
> no time at the moment to look at the issue itself, but:
>
> On Sun, Nov 09, 2014 at 12:00:24PM +0100, Michael Stapelberg wrote:
>> I would have tested and verified this and sent a patch, but there’s no
>> testsuite for this part of the code, so I couldn’t easily verify that
>> this was the problem and that my fix is correct, and neither could I
>> verify that the suggested fix doesn’t break anything else. Hence I’ll
>> leave it up to you to fix it.
>
> You missed the scripts in test/integration/. They do all sorts of stuff
> including starting our own webserver and running http/https against it.
> You can run them all with ./test/integration/run-tests or a specific one
> like ./test-partial-file-support which might be a good explicit test for
> this part (just because I remember writing it for 416 testing).
Thanks for pointing this out. However, it seems like these tests only
download a single file at a time, or am I misreading the source? (I
looked at downloadfile() in “framework”)
If correct, then I don’t think I can write a test case for the problem
at hand without also extending the test framework to first support
downloading multiple files over the same connection.
--
Best regards,
Michael
Reply to: