Cyril Brulebois <kibi@debian.org> (2014-03-13):
> Important note on interactivity:
> --------------------------------
> I've noticed the “apt-cdrom add” we have in apt-setup has a final
> “< /dev/null” to explicitly disable interactivity. I've tried patching
> all “apt-cdrom ident” calls to include that redirection as well, which
> affects the following files:
> generators/40cdrom
> generators/41cdset
> load-install-cd
>
> I've generated an ISO with the updated udebs, and the default install
> went through without any hangs. I've also verified half-way through
> that packages available in the ISO were seen this way in /target by
> apt, meaning only the missing packages were downloaded from the
> configurer network mirror.
>
> Initially, I wasn't too happy about patching apt-setup this late, but
> the code deduplication commit points out that “apt-cdrom add” and
> “apt-cdrom ident” are quite close, so maybe we should just release with
> a patched apt-setup, disabling interactivity for all “apt-cdrom
> {add,ident}” calls, and see how well it goes.
>
>
> Do (apt/d-i) folks think this is crazy, or worth a try?
So this commit landed in apt 0.9.16, uploaded today:
| commit b374004b8ffebe393c5fd5e8056f7a99849c0ebd
| Author: David Kalnischkies <david@kalnischkies.de>
| Date: Mon Mar 10 00:09:56 2014 +0100
|
| apt-cdrom ident shouldn't be interactive
|
| Commit 62dcbf84 changed the code of ident to look more like the code for
| add on my suggestion. This made ident interactive as it starts with a
| unmount, press enter, mount cycle. The first two are skipped now.
| This fixes d-i/apt-setup which is using it to get ID as well as label.
|
| Closes: 740673
Given it's bundled with a lot more changes, I don't feel like having apt
rushed into testing, so I'll probably push the “< /dev/null” bits to
apt-setup so as to disable interactivity from the caller, and get that
into testing urgently.
Mraw,
KiBi.
Attachment:
signature.asc
Description: Digital signature