Re: [PATCH 2/3] speed up Hex2Num

To: Jann Horn <jann@thejh.net>
Cc: deity@lists.debian.org
Subject: Re: [PATCH 2/3] speed up Hex2Num
From: Michael Vogt <mvo@debian.org>
Date: Mon, 27 Jan 2014 07:45:39 +0100
Message-id: <[🔎] 20140127064539.GH10489@bod>
In-reply-to: <[🔎] 1390616865-14817-3-git-send-email-jann@thejh.net>
References: <[🔎] 1390616865-14817-1-git-send-email-jann@thejh.net> <[🔎] 1390616865-14817-3-git-send-email-jann@thejh.net>

Hi Jann,

welcome and thanks for your work on analyzing and improving the apt
performance!

[..]
> +/* for Hex2Num */
> +static unsigned char hexdigits[256] =
> +   {99,99,99,99,99,99,99,99,99,99,99,99,99,99,99,99,
[..]
> +      if (digit1 == 99 || digit2 == 99)

Tiny nitpick, I would love to see something symbolic (a define or
const) here instead of "99". Like "ERR" or "INV" (invalid) or NaH
(Not-A-Hex) or something.

Cheers,
 Michael

Reply to:

References:
- [PATCH 0/3] speed up apt-get startup by ~19%
  - From: Jann Horn <jann@thejh.net>
- [PATCH 2/3] speed up Hex2Num
  - From: Jann Horn <jann@thejh.net>

Prev by Date: Re: [PATCH 3/3] debListParser::DescriptionLanguage: huge speedup
Next by Date: Re: [PATCH 0/3] speed up apt-get startup by ~19%
Previous by thread: Re: [PATCH 2/3] speed up Hex2Num
Next by thread: [PATCH 3/3] debListParser::DescriptionLanguage: huge speedup
Index(es):
- Date
- Thread