[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 1/3] speed up debVersioningSystem::DoCmpVersion a bit



On Sat, Jan 25, 2014 at 03:27:43AM +0100, Jann Horn wrote:
> ---
>  apt-pkg/deb/debversion.cc |   37 +++++++++++++++++++++++++------------
>  1 file changed, 25 insertions(+), 12 deletions(-)

Code alone, I thought this would be the biggest improvement, but after
checking I have to say that it is not visible on my machine.
(might try it later on an older armel box to get a better feel for it)
The code is simple, but I am still vary if we should use it.

Could you tell us why you think this is an improvement?

The implementation of memchr in eglibc I have seen comes certainly with
a setup cost, but after that it its highly optimized. Versionnumbers
aren't exactly long, but not very short either.


Best regards

David Kalnischkies

Attachment: signature.asc
Description: Digital signature


Reply to: