[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#733489: python-apt: Improve 'Dependency' and 'BaseDependency' to get target package versions that satisfy dependencies



On Tue, Dec 31, 2013 at 02:05:36PM +0100, Michael Schaller wrote:
> >You can just git-send-email them to the mailing list or even push a git
> >branch somewhere.
> >
> Alrighty. Then let's stick to the bug for the time being as it
> contains already the context for the patches.
> 
> See attached the patch with the PEP8 linter and pyflakes fixes. PEP8
> only showed typical minor issues (indentation, line continuation,
> ...) and pyflakes only found an unused import and an unused
> variable.

This looks good to me, thanks for doing this work. One minor note below:

[..]
> diff --git a/debian/changelog b/debian/changelog
> index 52a1000..a7b037d 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -3,6 +3,9 @@ python-apt (0.9.2) UNRELEASED; urgency=low
>    * apt/cache.py:
>      - when using apt.Cache(rootdir=/some/dir) only read the APT
>        configuration from this rootdir instead of /etc (closes: #728274)
> +    - Fixed PEP8 and pyflakes issues
> +  * apt/package.py:
> +    - Fixed PEP8 and pyflakes issues

Feel free to add yourself in the changelog, i.e. something like:

+ [ Michael Schaller ]
+  * apt/cache.py:
+    - Fixed PEP8 and pyflakes issues
+  * apt/package.py:
+    - Fixed PEP8 and pyflakes issues

Cheers,
 Michael


Reply to: