Re: [PATCH v2] apt-pkg:contrib Avoid compiler warning about sign-compare

2013/8/21 Julian Andres Klode <jak@debian.org>

On Wed, Aug 21, 2013 at 08:52:45PM +0200, Angel Guzman Maeso wrote:
> Hi apt developers,
>
> apt-pkg:contrib Avoid compiler warning about sign-compare
>
> The fix avoid the warning "comparison between signed and unsigned
> integer expressions [-Wsign-compare]"· The index for the loop
> needs to be unsigned for compare with globbuf.gl_pathc structure
> member.
>
> Regards,
> Ángel

This patch seems OK to me. The grammar in the description is slightly
wrong "The fix avoid" must either be "The fix avoids" (or "This fix
avoids") or can simply be "Avoid", as normally, you do not refer to
the patch itself as a subject (you don't mention the patch directly,
you only explain what it does). If you want to fix it, you can,
otherwise this can be merged directly.

--
Julian Andres Klode - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.

Thanks for the review Julian, I definitely need to improve my english grammar :)

I remove the "apt-pkg:contrib" in the commit title too (based in the other email review).

Let me know if it is ready now or I new update again some mistake.

Reply to: