Bug#703250: apt: failing tests in test/libapt does not cause FTBFS

[Niels Thykier <niels@thykier.net>]

On 2013-03-18 08:25, Michael Vogt wrote:
> On Mon, Mar 18, 2013 at 08:54:02AM +0800, Daniel Hartwig wrote:
>> On 18 March 2013 04:05, Michael Vogt <mvo@debian.org> wrote:
>>> This patch looks good! I commited it to bzr. Unfortunately its not
>>> sufficient as current a msgfail() in framework will not cause a != 0
>>> exit status. So to properly fix this some more work is needed.
>>>
>>> The attached (additional) patch should make it work now.
>>
>> Hello
>>
>> This makes it so the first failure prevents later tests in the same
>> file from running.  It can be bothersome to diagnose faults if e.g.
>> individual tests are not properly ordered, or are otherwise
>> independent of each other.  Some test frameworks avoid such early
>> abort and run all tests.
> 
> Great! I like this better than my original approach of failing too
> early. Attached is a small variation that will also count the number
> of failures, the obvious issue is that failure numbers > 255 in a
> single test can not be reported via the exit code. The diff is against
> your patch (and also against the "debian-sid" branch in bzr).
> 
> Cheers,
>  Michael
> 

Hi,

You may want to deploy the "overflow" guard to the integration test
runner as well[1].

~Niels

[1] i.e. test/integration/run-tests