On Sun, 17 Mar 2013 00:07:21 +0100 Serafeim Zanikolas wrote: > On Sat, Mar 16, 2013 at 11:25:18PM +0100, Francesco Poli wrote: > > On Sat, 16 Mar 2013 16:04:38 +0100 Serafeim Zanikolas wrote: > > > > [...] > > > I'm not sure any more that using a fifo instead of stdin is > > > needed for a "programmatic" frontend. After all, the tracebacks in #662983 > > > suggest that the failure occurs only when apt-listbugs tries to access > > > /dev/tty, at which point it has already parsed the apt hook data from stdin. > > > > It seems to me that you are right: if I recall correctly, the failure > > indeed happens after the hook info parsing step. > > Do you agree then that adding the fifo feature to apt and adapting > apt-listbugs accordingly is not needed nor does it suffice for fixing #662983? No, I don't agree. If I recall bug #662983 correctly, the trick is that, if apt-listbugs can read hook info through a named pipe, then it may interact with the user through stdin and stdout *without* having to explicitly reopen /dev/tty (this is the operation which is forbidden within an su -c command). Please see http://bugs.debian.org/662983#25 http://bugs.debian.org/662983#30 http://bugs.debian.org/662983#40 http://bugs.debian.org/662983#45 > > > Anyway, implementing a new alternative frontend is an even more radical > > modification for apt-listbugs. Let's not forget that here we were only > > talking about fixing #671726 and #671728 (in order to fix #662983 in a > > better way)... > > #662983, ie. relying on tty input, is not fixed by switching to a fifo: I've > reproduced the issue with fifo-based apt & apt-listbugs. I think this is due to the fact that your patch for apt-listbugs does not modify what apt-listbugs does *after* parsing the hook info sent by apt. I hope that all this makes sense and that I am not too tired to reply in a reasonable way... -- http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt New GnuPG key, see the transition document! ..................................................... Francesco Poli . GnuPG key fpr == CA01 1147 9CD2 EFDF FB82 3925 3E1C 27E1 1F69 BFFE
Attachment:
pgpj8_IAVkpiN.pgp
Description: PGP signature